fbinstant-deploy - npm Package Compare versions

Comparing version 0.0.5 to 0.0.6

main.js

@@ -12,3 +12,3 @@ const zipFolder = require('zip-folder');
                 console.log(e);
-                reject();
+                reject(e);
             } else {
@@ -22,56 +22,63 @@ resolve();
 function deploytoFacebook(accestoken, appid, file, comment = "") {
-    const url = `https://graph-video.facebook.com/${appid}/assets`;
-    request.post({
-        url: url,
-        formData: {
-            access_token: accestoken,
-            type: "BUNDLE",
-            comment: comment,
-            asset: {
-                value: fs.createReadStream(file),
-                options: {
-                    contentType: "application/octet-stream"
-                }
+    return new Promise((resolve, reject) => {
+        const url = `https://graph-video.facebook.com/${appid}/assets`;
+        request.post({
+            url: url,
+            formData: {
+                access_token: accestoken,
+                type: "BUNDLE",
+                comment: comment,
+                asset: {
+                    value: fs.createReadStream(file),
+                    options: {
+                        contentType: "application/octet-stream"
+                    }
+                },
             },
-        },
-    }, function (err, response, body) {
-        if (err) {
-            console.log(err);
-        }
-        const parsedBody = JSON.parse(body);
-        if (parsedBody.success) {
-            console.log("File deployed to Facebook!");
+        }, function (err, response, body) {
+            if (err) {
+                console.log(err);
+                reject(err);
+            }
+            const parsedBody = JSON.parse(body);
+            if (parsedBody.success) {
+                console.log("File deployed to Facebook!");
+                resolve();
+            } else {
+                console.error("Can't upload to Facebook: ", parsedBody.error.message + ` -- Code(${parsedBody.error.code})`);
+                reject();
+            }
+        })
+    });
+}
+
+function deploy(directory, accesstoken, appid, comment = "") {
+    directory = typeof directory == "string" ? directory : directory.toString();
+    accesstoken = typeof accesstoken == "string" ? accesstoken : accesstoken.toString();
+    appid = typeof appid == "string" ? appid : appid.toString();
+    comment = typeof comment == "string" ? comment : comment.toString();
+    return new Promise((resolve, reject) => {
+        if (directory || accesstoken || appid) {
+            directory = path.resolve(directory);
+            console.log(`Compressing directory: ${path.relative(__dirname, directory)}`);
+            return zipProject(directory).then(() => {
+                console.log(`Project file: ${path.relative(__dirname, directory)}.zip`);
+                console.log(`Deploying to facebook...`);
+                console.log(`\tAccessToken: ${accesstoken.substr(0, 10)}[...]`);
+                console.log(`\tAppId: ${appid}`);
+                deploytoFacebook(accesstoken, appid, `${directory}.zip`, comment).then(()=>{
+                    resolve();
+                });
+            }).catch((e) => {
+                console.log(e);
+                reject(e);
+            });
         } else {
-            console.error("Can't upload to Facebook: ", parsedBody.error.message + ` -- Code(${parsedBody.error.code})`);
+            let error = "A directory, accesstoken and appid are required";
+            console.error(error);
+            reject();
         }
-    })
+    });
 }
 
-function deploy(directory, accesstoken, appid, comment) {
-    if (directory || accesstoken || appid) {
-        directory = path.resolve(directory);
-        console.log(`Compressing directory: ${directory}...`);
-        return zipProject(directory).then(() => {
-            console.log(`Project has been zipped under ${directory}.zip`);
-            console.log(`Deploying to facebook...`);
-            console.log(`AccessToken: ${accesstoken}`);
-            console.log(`AppId: ${appid}`);
-            deploytoFacebook(accesstoken, appid, `${directory}.zip`, comment);
-        }).catch((e) => {
-            console.log(e);
-        });
-    } else {
-        if (!directory) {
-            console.error("directory is missing")
-        };
-        if (!accesstoken) {
-            console.error("accesstoken is missing")
-        };
-        if (!appid) {
-            console.error("appid is missing")
-        };
-    }
-
-}
-
 exports.deploy = deploy;

package.json

 {
   "name": "fbinstant-deploy",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "description": "Deployer for Facebook Instant Games",
@@ -5,0 +5,0 @@ "main": "main.js",

README.md

@@ -20,6 +20,6 @@ # Deployer for facebook instant games
 ```javascript
-const fbinstantDeploy = require("fbinstant-deploy");
-fbinstantDeploy.deploy("/some/dir/to/zip/", "access_token", "app_id", "some comment here").then(()=>{
+const instantDeployer = require("fbinstant-deploy");
+instantDeployer.deploy("/some/dir/to/zip/", "access_token", "app_id", "some comment here").then(()=>{
     console.log("Deployment successful!");
 });
 ```

No alert changes

Improved metrics

Total package byte prevSize

5400

increased by14.33%

Lines of code

77

increased by11.59%

No dependency changes