fellow - npm Package Compare versions

Comparing version 7.2.0 to 7.2.1-next.1703886933.6f88af1c9b2bb11560bf6771f1dc638f62765cb5

edition-browsers/index.js

@@ -635,3 +635,4 @@ // external
      * Compare to another fellow for equivalency.
-     * Uses {@link Fellow.ids} for the comparison.
+     * First checks if any of the ids match, using {@link Fellow.ids}, otherwise checks if their {@link Fellow.toString} result is the same, otherwise checks if one is only a name that matches the other.
+     * Note that `Adrian <[e-mail]>, Adrian` will not be de-duplicated, as no way to tell they are the same.
      * @param other The other fellow to compare ourselves with
@@ -641,9 +642,25 @@ * @returns Returns `true` if they appear to be the same person, or `false` if not.
     same(other) {
-        const ids = new Set(this.ids);
-        const otherIds = new Set(other.ids);
+        // compare id fields (emails, usernames)
+        const ids = this.ids;
+        const otherIds = other.ids;
         for (const id of ids) {
-            if (otherIds.has(id)) {
+            if (otherIds.includes(id)) {
                 return true;
             }
         }
+        // compare overall entity (name, email, urls including homepage)
+        const str = this.toString();
+        const otherStr = other.toString();
+        if (str === otherStr)
+            return true;
+        // if one of them is only the name, do the names match?
+        const name = this.name;
+        const otherName = other.name;
+        if (
+        /* names are the same */
+        name === otherName &&
+            /* this is only a name, or other is only a name */
+            (name === str || otherName === otherStr))
+            return true;
+        // no match
         return false;
@@ -650,0 +667,0 @@ }

edition-deno/index.ts

@@ -708,3 +708,4 @@ // external
 	 * Compare to another fellow for equivalency.
-	 * Uses {@link Fellow.ids} for the comparison.
+	 * First checks if any of the ids match, using {@link Fellow.ids}, otherwise checks if their {@link Fellow.toString} result is the same, otherwise checks if one is only a name that matches the other.
+	 * Note that `Adrian <[e-mail]>, Adrian` will not be de-duplicated, as no way to tell they are the same.
 	 * @param other The other fellow to compare ourselves with
@@ -714,9 +715,25 @@ * @returns Returns `true` if they appear to be the same person, or `false` if not.
 	same(other: Fellow): boolean {
-		const ids = new Set(this.ids)
-		const otherIds = new Set(other.ids)
+		// compare id fields (emails, usernames)
+		const ids = this.ids
+		const otherIds = other.ids
 		for (const id of ids) {
-			if (otherIds.has(id)) {
+			if (otherIds.includes(id)) {
 				return true
 			}
 		}
+		// compare overall entity (name, email, urls including homepage)
+		const str = this.toString()
+		const otherStr = other.toString()
+		if (str === otherStr) return true
+		// if one of them is only the name, do the names match?
+		const name = this.name
+		const otherName = other.name
+		if (
+			/* names are the same */
+			name === otherName &&
+			/* this is only a name, or other is only a name */
+			(name === str || otherName === otherStr)
+		)
+			return true
+		// no match
 		return false
@@ -723,0 +740,0 @@ }

edition-es2017-esm/index.js

@@ -650,3 +650,4 @@ // external
      * Compare to another fellow for equivalency.
-     * Uses {@link Fellow.ids} for the comparison.
+     * First checks if any of the ids match, using {@link Fellow.ids}, otherwise checks if their {@link Fellow.toString} result is the same, otherwise checks if one is only a name that matches the other.
+     * Note that `Adrian <[e-mail]>, Adrian` will not be de-duplicated, as no way to tell they are the same.
      * @param other The other fellow to compare ourselves with
@@ -656,9 +657,25 @@ * @returns Returns `true` if they appear to be the same person, or `false` if not.
     same(other) {
-        const ids = new Set(this.ids);
-        const otherIds = new Set(other.ids);
+        // compare id fields (emails, usernames)
+        const ids = this.ids;
+        const otherIds = other.ids;
         for (const id of ids) {
-            if (otherIds.has(id)) {
+            if (otherIds.includes(id)) {
                 return true;
             }
         }
+        // compare overall entity (name, email, urls including homepage)
+        const str = this.toString();
+        const otherStr = other.toString();
+        if (str === otherStr)
+            return true;
+        // if one of them is only the name, do the names match?
+        const name = this.name;
+        const otherName = other.name;
+        if (
+        /* names are the same */
+        name === otherName &&
+            /* this is only a name, or other is only a name */
+            (name === str || otherName === otherStr))
+            return true;
+        // no match
         return false;
@@ -665,0 +682,0 @@ }

edition-es2017/index.js

@@ -657,3 +657,4 @@ "use strict";
      * Compare to another fellow for equivalency.
-     * Uses {@link Fellow.ids} for the comparison.
+     * First checks if any of the ids match, using {@link Fellow.ids}, otherwise checks if their {@link Fellow.toString} result is the same, otherwise checks if one is only a name that matches the other.
+     * Note that `Adrian <[e-mail]>, Adrian` will not be de-duplicated, as no way to tell they are the same.
      * @param other The other fellow to compare ourselves with
@@ -663,9 +664,25 @@ * @returns Returns `true` if they appear to be the same person, or `false` if not.
     same(other) {
-        const ids = new Set(this.ids);
-        const otherIds = new Set(other.ids);
+        // compare id fields (emails, usernames)
+        const ids = this.ids;
+        const otherIds = other.ids;
         for (const id of ids) {
-            if (otherIds.has(id)) {
+            if (otherIds.includes(id)) {
                 return true;
             }
         }
+        // compare overall entity (name, email, urls including homepage)
+        const str = this.toString();
+        const otherStr = other.toString();
+        if (str === otherStr)
+            return true;
+        // if one of them is only the name, do the names match?
+        const name = this.name;
+        const otherName = other.name;
+        if (
+        /* names are the same */
+        name === otherName &&
+            /* this is only a name, or other is only a name */
+            (name === str || otherName === otherStr))
+            return true;
+        // no match
         return false;
@@ -672,0 +689,0 @@ }

edition-es2022/index.js

@@ -642,3 +642,4 @@ "use strict";
      * Compare to another fellow for equivalency.
-     * Uses {@link Fellow.ids} for the comparison.
+     * First checks if any of the ids match, using {@link Fellow.ids}, otherwise checks if their {@link Fellow.toString} result is the same, otherwise checks if one is only a name that matches the other.
+     * Note that `Adrian <[e-mail]>, Adrian` will not be de-duplicated, as no way to tell they are the same.
      * @param other The other fellow to compare ourselves with
@@ -648,9 +649,25 @@ * @returns Returns `true` if they appear to be the same person, or `false` if not.
     same(other) {
-        const ids = new Set(this.ids);
-        const otherIds = new Set(other.ids);
+        // compare id fields (emails, usernames)
+        const ids = this.ids;
+        const otherIds = other.ids;
         for (const id of ids) {
-            if (otherIds.has(id)) {
+            if (otherIds.includes(id)) {
                 return true;
             }
         }
+        // compare overall entity (name, email, urls including homepage)
+        const str = this.toString();
+        const otherStr = other.toString();
+        if (str === otherStr)
+            return true;
+        // if one of them is only the name, do the names match?
+        const name = this.name;
+        const otherName = other.name;
+        if (
+        /* names are the same */
+        name === otherName &&
+            /* this is only a name, or other is only a name */
+            (name === str || otherName === otherStr))
+            return true;
+        // no match
         return false;
@@ -657,0 +674,0 @@ }

edition-types/index.d.ts

@@ -191,3 +191,4 @@ /** Verify an email */
      * Compare to another fellow for equivalency.
-     * Uses {@link Fellow.ids} for the comparison.
+     * First checks if any of the ids match, using {@link Fellow.ids}, otherwise checks if their {@link Fellow.toString} result is the same, otherwise checks if one is only a name that matches the other.
+     * Note that `Adrian <[e-mail]>, Adrian` will not be de-duplicated, as no way to tell they are the same.
      * @param other The other fellow to compare ourselves with
@@ -194,0 +195,0 @@ * @returns Returns `true` if they appear to be the same person, or `false` if not.

package.json

 {
   "name": "fellow",
-  "version": "7.2.0",
+  "version": "7.2.1-next.1703886933.6f88af1c9b2bb11560bf6771f1dc638f62765cb5",
   "license": "Artistic-2.0",
@@ -259,8 +259,8 @@ "description": "Fellow is a package for creating people that can be unified by their shared values via a singleton list on the class",
     "kava": "^7.8.0",
-    "make-deno-edition": "^2.2.0",
+    "make-deno-edition": "^2.3.0",
     "prettier": "^3.1.1",
-    "projectz": "^4.1.1",
+    "projectz": "^4.2.0",
     "typedoc": "^0.25.4",
     "typescript": "5.3.3",
-    "valid-directory": "^4.8.0",
+    "valid-directory": "^4.9.0",
     "valid-module": "^2.6.0"
@@ -267,0 +267,0 @@ },

README.md

@@ -51,3 +51,3 @@ <!-- TITLE/ -->
 ``` typescript
-import pkg from 'https://unpkg.com/fellow@^7.2.0/edition-deno/index.ts'
+import pkg from 'https://unpkg.com/fellow@^7.2.1/edition-deno/index.ts'
 ```
@@ -58,3 +58,3 @@ ### [Skypack](https://www.skypack.dev "Skypack is a JavaScript Delivery Network for modern web apps")
 <script type="module">
-    import pkg from '//cdn.skypack.dev/fellow@^7.2.0'
+    import pkg from '//cdn.skypack.dev/fellow@^7.2.1'
 </script>
@@ -66,3 +66,3 @@ ```
 <script type="module">
-    import pkg from '//unpkg.com/fellow@^7.2.0'
+    import pkg from '//unpkg.com/fellow@^7.2.1'
 </script>
@@ -74,3 +74,3 @@ ```
 <script type="module">
-    import pkg from '//dev.jspm.io/fellow@7.2.0'
+    import pkg from '//dev.jspm.io/fellow@7.2.1'
 </script>
@@ -77,0 +77,0 @@ ```

source/index.ts

@@ -708,3 +708,4 @@ // external
 	 * Compare to another fellow for equivalency.
-	 * Uses {@link Fellow.ids} for the comparison.
+	 * First checks if any of the ids match, using {@link Fellow.ids}, otherwise checks if their {@link Fellow.toString} result is the same, otherwise checks if one is only a name that matches the other.
+	 * Note that `Adrian <[e-mail]>, Adrian` will not be de-duplicated, as no way to tell they are the same.
 	 * @param other The other fellow to compare ourselves with
@@ -714,9 +715,25 @@ * @returns Returns `true` if they appear to be the same person, or `false` if not.
 	same(other: Fellow): boolean {
-		const ids = new Set(this.ids)
-		const otherIds = new Set(other.ids)
+		// compare id fields (emails, usernames)
+		const ids = this.ids
+		const otherIds = other.ids
 		for (const id of ids) {
-			if (otherIds.has(id)) {
+			if (otherIds.includes(id)) {
 				return true
 			}
 		}
+		// compare overall entity (name, email, urls including homepage)
+		const str = this.toString()
+		const otherStr = other.toString()
+		if (str === otherStr) return true
+		// if one of them is only the name, do the names match?
+		const name = this.name
+		const otherName = other.name
+		if (
+			/* names are the same */
+			name === otherName &&
+			/* this is only a name, or other is only a name */
+			(name === str || otherName === otherStr)
+		)
+			return true
+		// no match
 		return false
@@ -723,0 +740,0 @@ }

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

264931

increased by2.09%

Lines of code

6292

increased by1.66%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

No dependency changes