fetch-h2 - npm Package Compare versions

Comparing version 0.2.5 to 0.2.6

dist/lib/fetch.js

@@ -202,3 +202,3 @@ 'use strict';
                     const status = '' + headers[HTTP2_HEADER_STATUS];
-                    const location = '' + headers[HTTP2_HEADER_LOCATION];
+                    const location = utils_1.parseLocation(headers[HTTP2_HEADER_LOCATION], url);
                     const isRedirected = isRedirectStatus[status];
@@ -205,0 +205,0 @@ if (headers[HTTP2_HEADER_SET_COOKIE]) {

dist/lib/generated/version.d.ts

@@ -1,1 +0,1 @@
-export declare const version = "0.2.5";
+export declare const version = "0.2.6";

dist/lib/generated/version.js

 'use strict';
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.version = '0.2.5';
+exports.version = '0.2.6';
 //# sourceMappingURL=version.js.map

dist/lib/utils.d.ts

 export declare function arrayify<T>(value: T | Array<T>): Array<T>;
 export declare function arrayify<T>(value: Readonly<T> | ReadonlyArray<T>): Array<T>;
+export declare function parseLocation(location: string, origin: string): string;

dist/lib/utils.js

 'use strict';
 Object.defineProperty(exports, "__esModule", { value: true });
+const url_1 = require("url");
 function arrayify(value) {
@@ -7,2 +8,9 @@ return Array.isArray(value) ? value : [value];
 exports.arrayify = arrayify;
+function parseLocation(location, origin) {
+    if ('string' !== typeof location)
+        return null;
+    const url = new url_1.URL(location, origin);
+    return url.href;
+}
+exports.parseLocation = parseLocation;
 //# sourceMappingURL=utils.js.map

dist/test/fetch-h2/nghttp2.org.js

@@ -75,3 +75,10 @@ 'use strict';
     });
+    it('should handle (and follow) relative paths', async () => {
+        const { fetch, disconnectAll } = _1.context();
+        const response = await fetch('https://nghttp2.org/httpbin/relative-redirect/2', { redirect: 'follow' });
+        chai_1.expect(response.url).to.equal("https://nghttp2.org/httpbin/get");
+        await response.text();
+        await disconnectAll();
+    });
 });
 //# sourceMappingURL=nghttp2.org.js.map

lib/fetch.ts

@@ -9,3 +9,3 @@ 'use strict'
 
-import { arrayify } from './utils'
+import { arrayify, parseLocation } from './utils'
 import {
@@ -338,3 +338,6 @@ Method,
 					const status = '' + headers[ HTTP2_HEADER_STATUS ];
-					const location = '' + headers[ HTTP2_HEADER_LOCATION ];
+					const location = parseLocation(
+						headers[ HTTP2_HEADER_LOCATION ],
+						url
+					);
 
@@ -341,0 +344,0 @@ const isRedirected = isRedirectStatus[ status ];

lib/generated/version.ts

 'use strict'
 
-export const version = '0.2.5';
+export const version = '0.2.6';

lib/utils.ts

 'use strict'
 
+import { URL } from 'url'
 import { Try } from 'already'
@@ -12,1 +13,10 @@
 }
+
+export function parseLocation( location: string, origin: string )
+{
+	if ( 'string' !== typeof location )
+		return null;
+
+	const url = new URL( location, origin );
+	return url.href;
+}

package.json

 {
   "name": "fetch-h2",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "description": "HTTP/2-only Fetch API client for Node.js",
@@ -5,0 +5,0 @@ "author": "Gustaf Räntilä",

test/fetch-h2/nghttp2.org.ts

@@ -118,3 +118,3 @@ 'use strict';
 			'https://nghttp2.org/httpbin/cookies/set?foo=bar',
-			{ redirect:'manual' } );
+			{ redirect: 'manual' } );
 
@@ -131,3 +131,16 @@ expect( responseSet.headers.has( 'location' ) ).to.be.true;
 	} );
+
+	it( 'should handle (and follow) relative paths', async ( ) =>
+	{
+		const { fetch, disconnectAll } = context( );
+
+		const response = await fetch(
+			'https://nghttp2.org/httpbin/relative-redirect/2',
+			{ redirect: 'follow' } );
+
+		expect( response.url ).to.equal( "https://nghttp2.org/httpbin/get" );
+		await response.text( );
+
+		await disconnectAll( );
+	} );
 } );
-

No alert changes

Improved metrics

Total package byte prevSize

3130543

increased by0.06%

Lines of code

6385

increased by0.58%

Worsened metrics

Number of medium supply chain risk alerts

23

increased by4.55%

No dependency changes