flora-solr - npm Package Compare versions

Comparing version 0.6.0 to 0.6.1

index.js

@@ -9,6 +9,6 @@ 'use strict';
 var errors = require('flora-errors');
-var RequestError = errors.RequestError;
 var ImplementationError = errors.ImplementationError;
 
 var SUPPORTED_FILTERS = ['equal', 'notEqual', 'lessOrEqual', 'greaterOrEqual', 'range'];
+var NO_LIMIT = 1000000;
 
@@ -57,3 +57,3 @@ /**
 
-    if (!request.limit) request.limit = 1000000; // overwrite SOLR default limit for sub-resource processing
+    if (!request.limit) request.limit = NO_LIMIT; // overwrite SOLR default limit for sub-resource processing
     if (request.page) params.start = (request.page - 1) * request.limit;
@@ -68,3 +68,4 @@
             'group.field': request.limitPer,
-            'group.limit': request.limit
+            'group.limit': request.limit,
+            rows: NO_LIMIT // disable default limit because groups are returned as list
         });
@@ -286,13 +287,10 @@ }
         res.on('end', function () {
-            var data, error;
+            var data = parseData(Buffer.concat(chunks).toString('utf8'));
 
-            data = parseData(Buffer.concat(chunks).toString('utf8'));
             if (res.statusCode >= 400 || data instanceof Error) {
-                if (!(data instanceof Error)) {
-                    if (res.statusCode > 400) error = new Error(http.STATUS_CODES[res.statusCode]);
-                    else if (res.statusCode === 400) error = new RequestError(data.error.msg);
-                    error.code = res.statusCode;
-                } else {
-                    error = data;
-                    error.code = 502;
+                var error = new Error('Solr error: ' + res.statusCode + ' ' + http.STATUS_CODES[res.statusCode]);
+                if (data instanceof Error) {
+                    error.message += ': ' + data.message;
+                } else if (data && data.error && data.error.msg) {
+                    error.message += ': ' + data.error.msg;
                 }
@@ -299,0 +297,0 @@

package.json

 {
   "name": "flora-solr",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "Solr connection for Flora",
@@ -42,16 +42,16 @@ "main": "index.js",
     "chai": "^3.4.1",
-    "eslint": "^2.3.0",
-    "grunt": "^0.4.5",
-    "grunt-cli": "^0.1.13",
+    "eslint": "^3.2.2",
+    "grunt": "^1.0.1",
+    "grunt-cli": "^1.2.0",
     "grunt-contrib-clean": "^1.0.0",
-    "grunt-eslint": "^18.0.0",
-    "grunt-mocha-istanbul": "^3.0.1",
+    "grunt-eslint": "^19.0.0",
+    "grunt-mocha-istanbul": "^5.0.1",
     "grunt-mocha-test": "^0.12.7",
     "istanbul": "^0.4.2",
     "load-grunt-tasks": "^3.4.0",
-    "mocha": "^2.3.4",
+    "mocha": "^3.0.0",
     "mocha-bamboo-reporter": "^1.1.0",
-    "nock": "7.2.x",
+    "nock": "8.0.x",
     "when": "^3.7.7"
   }
 }

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

13903

increased by0.02%

Number of medium supply chain risk alerts

1

decreased by-50%

Worsened metrics

Lines of code

298

decreased by-0.67%

No dependency changes