gardr-host - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

lib/manager.js

@@ -258,2 +258,3 @@ /* jshint maxparams:4 */
     }
+    this.pluginApi.trigger('item:afterrender', item);
     if (item && typeof item.options[type] == 'function'){
@@ -260,0 +261,0 @@ item.options[type](error, item);

package.json

 {
   "name": "gardr-host",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "The js part of Gardr which insert and talks with the iframes on the host page",
@@ -5,0 +5,0 @@ "main": "./lib/index.js",

test/manager.test.js

@@ -646,3 +646,3 @@ /*jshint expr: true, nonew: false*/
             manager.pluginApi.on('item:beforerender', function (item) {
-                expect(item.name).to.equal(name);
+                if (item.name !== name) { return; }
                 expect(item.options.container).to.exist;
@@ -656,3 +656,18 @@ expect(item.iframe).not.to.exist;
         });
+
+        it('should trigger item:afterrender when the iframe has been rendered', function (done) {
+            var name = helpers.getRandomName();
+
+            manager.pluginApi.on('item:afterrender', function (item) {
+                if (item.name !== name) { return; }
+                expect(item.iframe).to.exist;
+                expect(item.rendered.width).to.equal(310);
+                expect(item.rendered.height).to.equal(225);
+                done();
+            });
+
+            manager.queue(name, {url: 'about:blank'});
+            manager.render(name);
+        });
     });
 });

No alert changes

Improved metrics

Total package byte prevSize

54328

increased by1.18%

Lines of code

1294

increased by1.01%

No dependency changes