gooddata - npm Package Compare versions

Comparing version 4.4.1 to 4.5.0-tomasreichmann-TRE-RAIL-351-Attribute-Elements-2017-12-18T14-16-15-808Z

index.d.ts

@@ -35,11 +35,11 @@ // Copyright (C) 2007-2017, GoodData(R) Corporation. All rights reserved.
 export interface IValidElementsOptions {
-    limit: number;
-    offset: number;
-    order: SortDirection;
-    filter: string;
-    prompt: string;
-    uris: string[];
-    complement: boolean;
-    includeTotalCountWithoutFilters: boolean;
-    restrictiveDefinition: string;
+    limit?: number;
+    offset?: number;
+    order?: SortDirection;
+    filter?: string;
+    prompt?: string;
+    uris?: string[];
+    complement?: boolean;
+    includeTotalCountWithoutFilters?: boolean;
+    restrictiveDefinition?: string;
 }
@@ -46,0 +46,0 @@

lib/xhr.js

@@ -218,5 +218,9 @@ 'use strict';
         if (response.status === 202 && !settings.dontPollOnResult) {
+            // poll on new provided url, fallback to the original one
+            // (for example validElements returns 303 first with new url which may then return 202 to poll on)
+            var finalUrl = response.url || url;
+
+            var finalSettings = settings;
+
             // if the response is 202 and Location header is not empty, let's poll on the new Location
-            var finalUrl = url;
-            var finalSettings = settings;
             if (response.headers.has('Location')) {
@@ -228,2 +232,3 @@ finalUrl = response.headers.get('Location');
             delete finalSettings.body;
+
             return handlePolling(finalUrl, finalSettings, ajax);
@@ -230,0 +235,0 @@ }

package.json

 {
   "name": "gooddata",
-  "version": "4.4.1",
+  "version": "4.5.0-tomasreichmann-TRE-RAIL-351-Attribute-Elements-2017-12-18T14-16-15-808Z",
   "author": "GoodData",
@@ -5,0 +5,0 @@ "description": "GoodData JavaScript SDK",

src/xhr.js

@@ -201,5 +201,9 @@ // Copyright (C) 2007-2013, GoodData(R) Corporation. All rights reserved.
         if (response.status === 202 && !settings.dontPollOnResult) {
+            // poll on new provided url, fallback to the original one
+            // (for example validElements returns 303 first with new url which may then return 202 to poll on)
+            let finalUrl = response.url || url;
+
+            const finalSettings = settings;
+
             // if the response is 202 and Location header is not empty, let's poll on the new Location
-            let finalUrl = url;
-            const finalSettings = settings;
             if (response.headers.has('Location')) {
@@ -211,2 +215,3 @@ finalUrl = response.headers.get('Location');
             delete finalSettings.body;
+
             return handlePolling(finalUrl, finalSettings, ajax);
@@ -213,0 +218,0 @@ }

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

Deprecated

Maintenance

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1131793

increased by0.07%

Lines of code

26529

increased by0.02%

Number of medium maintenance alerts

0

decreased by-100%

Worsened metrics

Number of low quality alerts

2

increased by100%

Number of medium supply chain risk alerts

7

increased by16.67%

No dependency changes