happn-logger - npm Package Compare versions

Comparing version 0.0.2 to 0.1.0

lib/logger.js

@@ -94,3 +94,3 @@ var util = require('util');
 
-  // only build the log4js config if not defined 
+  // only build the log4js config if not defined
   if (!Config.logger) {
@@ -209,2 +209,5 @@
 
+    if (level == 'error')
+      Config.logWriter[level](array.pop());
+
     if (Config.logStackTraces) {
@@ -224,5 +227,4 @@ if (last = array[array.length -1]) {
     emitter.emit('after', level, string, Config.logStackTraces?last:null);
-
   };
-} 
+}
 
@@ -263,8 +265,5 @@ module.exports.createContext = function(context) {
 
-  if (listener){
-    console.log('set listener:::');
+  if (listener)
     Config.listener = listener;
-  }
 
-
   if (!obj) {
@@ -304,3 +303,12 @@ logger.createLogger = function(component) {
     var array, message = util.format.apply(this, arguments);
+
+    var e = new Error();
+    var regex = /\((.*):(\d+):(\d+)\)$/
+    var match = regex.exec(e.stack.split("\n")[2]);
+
     if (Config.logStackTraces) array = Array.prototype.slice.call(arguments);
+    else array = new Array();
+
+    array.push('file path: ' + match[1] + ' line: ' + match[2] + ' column: ' + match[3]);
+
     Config.log('error', thisContext.value, component, message, array);
@@ -307,0 +315,0 @@ }

package.json

 {
   "name": "happn-logger",
-  "version": "0.0.2",
+  "version": "0.1.0",
   "description": "Logger using log4js",
@@ -5,0 +5,0 @@ "main": "index.js",

test/logger_test.js

@@ -95,3 +95,3 @@ var should = require('chai').should();
       var log = Logger.createLogger();
-      
+
       Logger.config.logWriter.isInfoEnabled = done;
@@ -200,2 +200,36 @@ log.info('message');
 
+    it('includes the line number and filename of the caller if we log an error without an error object', function(done) {
+      try {
+        fs.unlinkSync('file.log');
+      } catch (e) {}
+      Logger.configure({
+        logFile: 'file.log'
+      });
+      var log = Logger.createLogger('component');
+      log.error('xxxxx');
+      setTimeout(function() {
+        var logged = fs.readFileSync('file.log').toString();
+        logged.should.match(/ \[ERROR\] - file path:/);
+        fs.unlinkSync('file.log');
+        done();
+      }, 100);
+    });
+
+    it('includes the line number and filename of the caller if we log an error with an error object', function(done) {
+      try {
+        fs.unlinkSync('file.log');
+      } catch (e) {}
+      Logger.configure({
+        logFile: 'file.log'
+      });
+      var log = Logger.createLogger('component');
+      log.error('xxxxx', new Error('test error'));
+      setTimeout(function() {
+        var logged = fs.readFileSync('file.log').toString();
+        console.log('logged:::', logged);
+        logged.should.match(/ \[ERROR\] - file path:/);
+        fs.unlinkSync('file.log');
+        done();
+      }, 100);
+    });
   });
@@ -228,3 +262,3 @@
       log3.info('message 3');
-      
+
       context.context = 'xxx';
@@ -362,3 +396,3 @@
         },
-        
+
       ])
@@ -385,3 +419,3 @@
       var component3 = Logger.createLogger('component3');
-      
+
       component1.info('aaaaa');
@@ -414,3 +448,3 @@ component2.info('bbbbb');
       var component4 = Logger.createLogger('component4');
-      
+
       component2.fatal('aaaaa');
@@ -417,0 +451,0 @@ component3.error('bbbbb');

No alert changes

Improved metrics

Lines of code

745

increased by5.37%

Worsened metrics

Total package byte prevSize

34153

decreased by-35.86%

Number of package files

8

decreased by-33.33%

No dependency changes