httplease - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

package.json

 {
   "name": "httplease",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "HTTP client library with support for pluggable filters, including Zipkin, ASAP, etc",
@@ -12,2 +12,10 @@ "main": "index.js",
   },
+  "repository": "bitbucket:atlassianlabs/httplease",
+  "keywords": [
+    "http",
+    "request",
+    "promise",
+    "caching",
+    "filters"
+  ],
   "author": "",
@@ -27,2 +35,3 @@ "license": "Apache-2.0",
     "jasmine-http-server-spy": "^0.1.1",
+    "jasmine-promise-tools": "^1.0.0",
     "jsonwebtoken": "^5.7.0",
@@ -29,0 +38,0 @@ "proxyquire": "^1.7.4"

test/integration/httpRequest.it.spec.js

 'use strict';
 
-let willResolve = require('../support/willResolve');
 let describeIntegrationSupport = require('../support/describeIntegrationSupport');
@@ -85,8 +84,8 @@
     it('handles socket errors by rejecting', willResolve(() => {
-        return httpClient
+        let promise = httpClient
             .withMethodGet()
-            .send({basePath: 'http://bad.invalid', path: '/foo'})
-            .then(() => {
-                fail('Expected promise to reject!');
-            }, (err) => {
+            .send({basePath: 'http://bad.invalid', path: '/foo'});
+
+        return expectToReject(promise)
+            .then((err) => {
                 expect(httpSpy.getHandler).not.toHaveBeenCalled();
@@ -93,0 +92,0 @@ expect(err.code).toBe('ENOTFOUND');

test/integration/jwtAuthFilter.it.spec.js

 'use strict';
 
-let willResolve = require('../support/willResolve');
 let describeIntegrationSupport = require('../support/describeIntegrationSupport');
@@ -5,0 +4,0 @@ let createJwtAuthFilter = require('../../index').filters.createJwtAuthFilter;

test/integration/statusFilter.it.spec.js

 'use strict';
 
-let willResolve = require('../support/willResolve');
 let describeIntegrationSupport = require('../support/describeIntegrationSupport');
@@ -31,10 +30,10 @@ let expectResponseStatus = require('../../index').filters.expectResponseStatus;
     it('should reject unexpected response statuses', willResolve(() => {
-        return httpClient
+        let promise = httpClient
             .withFilter(expectResponseStatus([201]))
             .withPath('/get')
             .withMethodGet()
-            .send()
-            .then(() => {
-                fail('Expected promise to reject!');
-            }, (err) => {
+            .send();
+
+        return expectToReject(promise)
+            .then((err) => {
                 expect(err.httpResponse.status).toBe(200);
@@ -41,0 +40,0 @@ expect(err.message).toBe(

test/integration/streaming.it.spec.js

@@ -7,3 +7,2 @@ 'use strict';
 
-let willResolve = require('../support/willResolve');
 let describeIntegrationSupport = require('../support/describeIntegrationSupport');
@@ -10,0 +9,0 @@

test/unit/core/httpRequest.spec.js

@@ -6,4 +6,2 @@ 'use strict';
 
-let willResolve = require('../../support/willResolve');
-
 describe('httpRequest', () => {
@@ -10,0 +8,0 @@ let request;

test/unit/core/httpRequestBuilder.spec.js

@@ -6,5 +6,3 @@ 'use strict';
 
-let willResolve = require('../../support/willResolve');
 
-
 describe('httpRequestBuilder', () => {
@@ -11,0 +9,0 @@ let mockRequestPipeline;

test/unit/core/requestPipeline.spec.js

@@ -7,4 +7,2 @@ 'use strict';
 
-let willResolve = require('../../support/willResolve');
-
 describe('requestPipeline', () => {
@@ -271,2 +269,2 @@ let requestConfig;
     });
-});
+});

test/unit/filters/jwtAuthFilter.spec.js

@@ -5,3 +5,2 @@ 'use strict';
 var jsonWebToken = require('jsonwebtoken');
-let willResolve = require('../../support/willResolve');
 
@@ -8,0 +7,0 @@ let createJwtAuthFilter = require('../../../lib/filters/jwtAuthFilter');

test/unit/filters/statusFilter.spec.js

 'use strict';
 
 let q = require('q');
-let willResolve = require('../../support/willResolve');
 
@@ -6,0 +5,0 @@ let expectResponseStatus = require('../../../lib/filters/statusFilter');

Fixed alerts

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

52153

decreased by-0.85%

Dev dependency count

8

increased by14.29%

Lines of code

1231

decreased by-1.52%

No dependency changes