json-schema-table - npm Package Compare versions

Comparing version 0.0.3 to 0.0.4

index.js

@@ -140,7 +140,8 @@ var _ = require('lodash');
   });
-  assert(primaryKey.length, 'Table ' + tableName + ' has no primary keys');
-  columns.push('CONSTRAINT ' + wrap(buildPkConstraintName(tableName, primaryKey), delimiters) +
-    ' PRIMARY KEY (' + primaryKey.map(function(column) {
-      return wrap(column, delimiters);
-    }).join(',') + ')');
+  if (primaryKey.length) {
+    columns.push('CONSTRAINT ' + wrap(buildPkConstraintName(tableName, primaryKey), delimiters) +
+      ' PRIMARY KEY (' + primaryKey.map(function(column) {
+        return wrap(column, delimiters);
+      }).join(',') + ')');
+  }
 
@@ -189,3 +190,2 @@ return dialect.name === 'mssql' ?
   });
-  assert(primaryKey.length, 'Table ' + tableName + ' has no primary keys');
   var oldPrimaryKey = metadata.tablesWithPrimaryKey[tableName].map(function(column) {
@@ -195,9 +195,13 @@ return column.column;
   if (_.difference(primaryKey, oldPrimaryKey).length) {
-    commands.push('ALTER TABLE ' + wrap(tableName, delimiters) + ' DROP CONSTRAINT '
-      + wrap(buildPkConstraintName(tableName, oldPrimaryKey), delimiters));
-    commands.push('ALTER TABLE ' + wrap(tableName, delimiters) + ' ADD CONSTRAINT '
-      + wrap(buildPkConstraintName(tableName, primaryKey), delimiters) + ' PRIMARY KEY (' +
-      primaryKey.map(function(column) {
-        return wrap(column, delimiters);
-      }).join(',') + ')');
+    if (oldPrimaryKey.length) {
+      commands.push('ALTER TABLE ' + wrap(tableName, delimiters) + ' DROP CONSTRAINT '
+        + wrap(buildPkConstraintName(tableName, oldPrimaryKey), delimiters));
+    }
+    if (primaryKey.length) {
+      commands.push('ALTER TABLE ' + wrap(tableName, delimiters) + ' ADD CONSTRAINT '
+        + wrap(buildPkConstraintName(tableName, primaryKey), delimiters) + ' PRIMARY KEY (' +
+        primaryKey.map(function(column) {
+          return wrap(column, delimiters);
+        }).join(',') + ')');
+    }
   }
@@ -204,0 +208,0 @@ return commands.join(';');

package.json

 {
   "name": "json-schema-table",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "Creates and maintains a SQL table structure",
@@ -5,0 +5,0 @@ "homepage": "",

No alert changes

Improved metrics

Lines of code

1232

increased by0.33%

Worsened metrics

Total package byte prevSize

51157

decreased by-0.05%

No dependency changes