kafkajs - npm Package Compare versions

Comparing version 1.4.7 to 1.4.8

CHANGELOG.md

@@ -8,2 +8,10 @@ # Changelog
 
+## [1.4.8] - 2019-02-18
+
+### Fixed
+  - Handle undefined message key when producing with 0.11 #247
+  - Fix consumer restart on find coordinator errors #253
+  - Crash consumer on codec not implemented error #256
+  - Fix error message on invalid username or password #270
+
 ## [1.4.7] - 2019-01-17
@@ -10,0 +18,0 @@

package.json

 {
   "name": "kafkajs",
-  "version": "1.4.7",
+  "version": "1.4.8",
   "description": "A modern Apache Kafka client for node.js",
@@ -56,3 +56,4 @@ "author": "Tulio Ornelas <[e-mail]>",
     "ip": "^1.1.5",
-    "jest": "^23.5.0",
+    "jest": "^24.0.0",
+    "jest-extended": "^0.11.0",
     "jest-junit": "^5.1.0",
@@ -59,0 +60,0 @@ "lint-staged": "^6.0.0",

src/broker/saslAuthenticator/scram.js

@@ -132,3 +132,3 @@ const crypto = require('crypto')
     if (sasl.username == null || sasl.password == null) {
-      throw new KafkaJSSASLAuthenticationError('SASL Plain: Invalid username or password')
+      throw new KafkaJSSASLAuthenticationError(`${this.PREFIX}: Invalid username or password`)
     }
@@ -135,0 +135,0 @@

src/cluster/index.js

@@ -239,2 +239,9 @@ const BrokerPool = require('./brokerPool')
 
+        if (e.code === 'ECONNREFUSED') {
+          // During maintenance the current coordinator can go down; findBroker will
+          // refresh metadata and re-throw the error. findGroupCoordinator has to re-throw
+          // the error to go through the retry cycle.
+          throw e
+        }
+
         bail(e)
@@ -241,0 +248,0 @@ }

src/consumer/runner.js

@@ -310,2 +310,6 @@ const createRetry = require('../retry')
 
+        if (e.name === 'KafkaJSNotImplemented') {
+          return bail(e)
+        }
+
         this.logger.debug('Error while fetching data, trying again...', {
@@ -312,0 +316,0 @@ groupId: this.consumerGroup.groupId,

src/protocol/encoder.js

@@ -48,3 +48,3 @@ const Long = require('long')
   static sizeOfVarIntBytes(value) {
-    const size = value === null ? -1 : Buffer.byteLength(value)
+    const size = value == null ? -1 : Buffer.byteLength(value)
 
@@ -51,0 +51,0 @@ if (size < 0) {

src/protocol/requests/fetch/v4/response.js

@@ -53,2 +53,4 @@ const Decoder = require('../../../decoder')
         }
+
+        throw e
       }
@@ -55,0 +57,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

507493

increased by4.38%

Lines of code

9132

increased by0.11%

Worsened metrics

Dev dependency count

19

increased by5.56%

No dependency changes