loopback-connector - npm Package Compare versions

Comparing version 2.1.1 to 2.1.2

CHANGES.md

@@ -0,1 +1,9 @@
[phone], Version 2.1.2
+=========================
+
+ * Fix for https://github.com/strongloop/loopback-connector-mssql/issues/45 (Raymond Feng)
+
+ * Fix the jsdoc for applyPagination (Raymond Feng)
+
+
 2015-05-20, Version 2.1.1
@@ -2,0 +10,0 @@ =========================

lib/sql.js

@@ -863,17 +863,21 @@ var util = require('util');
     var p = props[key];
+    if (p == null) {
+      // Unknown property, ignore it
+      debug('Unknown property %s is skipped for model %s', key, model);
+      continue;
+    }
     if (excludeIds && p.id) {
       continue;
     }
-    if (p) {
-      var k = this.columnEscaped(model, key);
-      var v = this.toColumnValue(p, data[key]);
-      if (v !== undefined) {
-        fields.names.push(k);
-        if (v instanceof ParameterizedSQL) {
-          fields.columnValues.push(v);
-        } else {
-          fields.columnValues.push(new ParameterizedSQL(PLACEHOLDER, [v]));
-        }
-        fields.properties.push(p);
+
+    var k = this.columnEscaped(model, key);
+    var v = this.toColumnValue(p, data[key]);
+    if (v !== undefined) {
+      fields.names.push(k);
+      if (v instanceof ParameterizedSQL) {
+        fields.columnValues.push(v);
+      } else {
+        fields.columnValues.push(new ParameterizedSQL(PLACEHOLDER, [v]));
       }
+      fields.properties.push(p);
     }
@@ -1296,5 +1300,3 @@ }
  * @param {ParameterizedSQL} stmt The sql statement
- * @param {Number} limit The maximum number of records to be fetched
- * @param {Number} offset The offset to start fetching records
- * @param {String[]} order The sorting criteria
+ * @param {Object} filter The filter object from the query
  */
@@ -1301,0 +1303,0 @@ SQLConnector.prototype.applyPagination = function(model, stmt, filter) {

package.json

 {
   "name": "loopback-connector",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "Building blocks for LoopBack connectors",
@@ -5,0 +5,0 @@ "keywords": [

test/sql.test.js

@@ -146,3 +146,4 @@ var expect = require('chai').expect;
   it('builds fields for columns', function() {
-    var fields = connector.buildFields('customer', {name: 'John', vip: true});
+    var fields = connector.buildFields('customer',
+      {name: 'John', vip: true, unknown: 'Random'});
     expect(fields.names).to.eql(['`NAME`', '`VIP`']);
@@ -149,0 +150,0 @@ expect(fields.columnValues[0].toJSON()).to.eql(

No alert changes

Improved metrics

Total package byte prevSize

333091

increased by0.06%

Lines of code

2396

increased by0.08%

No dependency changes