mesosphere-shared-reactjs - npm Package Compare versions

Comparing version 0.0.18 to 0.0.19

index.js

@@ -5,3 +5,2 @@ var ClassMixin = require("./utils/ClassUtil").mixin;
 var StoreMixin = require("./mixins/StoreMixin");
-var Store = require("./utils/Store");
 
@@ -12,4 +11,3 @@ module.exports = {
   StoreMixin: StoreMixin,
-  RequestUtil: RequestUtil,
-  Store: Store
+  RequestUtil: RequestUtil
 };

mixins/StoreMixin.js

@@ -57,2 +57,4 @@ var StringUtil = require('../utils/StringUtil');
 
+    // TODO: this.store_listeners gets changed from an array to an object here.
+    // We shouldn't modify the structure
     this.store_listeners = storesListeners;
@@ -80,5 +82,12 @@ this.store_addListeners();
       var listenerDetail = this.store_listeners[storeID];
+      var events = listenerDetail.events;
 
+      // Check that we actually have events to fire events on
+      if (process.env.NODE_ENV !== 'production' &&
+        (typeof events !== 'object' || !Object.keys(events).length)) {
+        throw new Error('No events found on listener configuration for store ' +
+          'with ID "' + storeID + '".');
+      }
       // Loop through all available events
-      Object.keys(listenerDetail.events).forEach(function (event) {
+      Object.keys(events).forEach(function (event) {
         var eventListenerID = event + LISTENER_SUFFIX;
@@ -98,3 +107,3 @@
         listenerDetail.store.addChangeListener(
-          listenerDetail.events[event], listenerDetail[eventListenerID]
+          events[event], listenerDetail[eventListenerID]
         );
@@ -152,6 +161,3 @@ }.bind(this));
     // Call callback on component that implements mixin if it exists
-    var onChangeFn = this.store_getChangeFunctionName(
-      listenerDetail.storeID || listenerDetail.store.storeID,
-      event
-    );
+    var onChangeFn = this.store_getChangeFunctionName(storeID, event);
 
@@ -158,0 +164,0 @@ if (this[onChangeFn]) {

package.json

 {
   "name": "mesosphere-shared-reactjs",
-  "version": "0.0.18",
+  "version": "0.0.19",
   "description": "Shared code from mesosphere web projects",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

53762

decreased by-0.92%

Number of package files

18

decreased by-5.26%

Lines of code

1130

decreased by-2.08%

Number of low supply chain risk alerts

1

increased byInfinity%

No dependency changes