next-biz-date - npm Package Compare versions

Comparing version 2.0.3 to 2.1.0

main.js

 (() => {
   const moment = require("moment");
+  const memoize = require("memoizee");
 
@@ -55,11 +56,2 @@ /***
 
-  let isBusinessDay_Cache = [];
-  function isBusinessDay_getFromCache(mCandidateDate) {
-    for (idx = 0; idx < isBusinessDay_Cache.length; idx++) {
-      let cachedItem = isBusinessDay_Cache[idx];
-      if (cachedItem.cachedDate.isSame(mCandidateDate)) {
-        return cachedItem.result;
-      }
-    }
-  }
   /**
@@ -75,9 +67,3 @@ * Deterimnes if provided candidateDate exists in the holidays array
 
-    let cachedResult = isBusinessDay_getFromCache(mCandidateDate);
-    if (cachedResult !== undefined) {
-      return cachedResult;
-    }
-
     if (dow === 6 || dow === 0) {
-      isBusinessDay_Cache.push({cachedDate: mCandidateDate, result: false});
       return false;
@@ -89,8 +75,5 @@ }
       if (mHolidayAtStake.isSame(mCandidateDate)) {
-        isBusinessDay_Cache.push({cachedDate: mCandidateDate, result: false});
         return false;
       }
     }
-
-    isBusinessDay_Cache.push({cachedDate: mCandidateDate, result: true});
     return true;
@@ -199,4 +182,4 @@ }
 
-  exports.FindBizDate = findBizDate;
-  exports.FindNextBizDate = findNextBizDate;
+  exports.FindBizDate = memoize(findBizDate);
+  exports.FindNextBizDate = memoize(findNextBizDate);
 })();

package.json

 {
   "name": "next-biz-date",
-  "version": "2.0.3",
-  "description": "Returns the next business date for a given reference date (initialDate), an offset count value, a direction (FORWARD or BACKWARDS) and a given array of holidays",
+  "version": "2.1.0",
+  "description": "Returns the next business date for a given reference date (initialDate), an offset count value, a direction (FORWARD or BACKWARDS) and a given array of holidays. This package is optimized by memoization techniques.",
   "main": "main.js",
@@ -34,2 +34,3 @@ "scripts": {
   "dependencies": {
+    "memoizee": "^0.4.14",
     "moment": "^2.29.1"
@@ -36,0 +37,0 @@ },

test/tests.js

@@ -114,3 +114,3 @@ const assert = require("assert");
       {baseDate: "2020-12-19", offset: 11 /* WW1234HWWH567HWWH8901 */, expectedResult: "2021-01-08"},
-      
+
       {baseDate: "2020-12-24", offset: 4 /* WW1234HWWH567HWWH8901 */, expectedResult: "2021-01-05"},
@@ -183,14 +183,22 @@ ];
 
-  it("Should support 11000 iterations in reasonable time", () => {
+  const targetYears = 1;
+  const targetFFDays = 1;
+  it(`Should support ${targetYears} years of days iterations in reasonable time`, () => {
+    
+    console.log(`COUNTING ${targetFFDays} days FOR ${targetYears} YEARS...`);
 
-    const cornerCase = {baseDate: "2020-12-19", expectedResult: "2020-12-16"};
-    let i = 0;
-    let result;
-    for (i = 0; i < 11000; i++) {
-      result = nbd.FindNextBizDate(cornerCase.baseDate, holidays, 2, "BACKWARDS");
+    let volumeTestItem = moment("2010-01-01");
+    const volumeTests = [];
+    for (vt = 0; vt < 365 * targetYears; vt++) {
+      volumeTests.push(moment(volumeTestItem));
+      volumeTestItem = volumeTestItem.add(1, "days");
     }
-    console.log(`FINISHED AFTER ${i} iterations`, result);
-    assert.equal(result.isSame(moment(cornerCase.expectedResult)), true);
-    
+
+    volumeTests.forEach((item) => {
+      result = nbd.FindNextBizDate(item, holidays, targetFFDays, "FORWARD");
+    });
+
+    console.log(`FINISHED AFTER PROCESSING ${volumeTests.length} days that counted forward ${targetFFDays} business days each!`);
+
   });
 });

No alert changes

Worsened metrics

Total package byte prevSize

20084

decreased by-1.35%

Dependency count

2

increased by100%

Lines of code

346

decreased by-2.81%

Dependency changes

• + Addedmemoizee@^0.4.14

• + Addedd@1.0.2(transitive)

• + Addedes5-ext@0.10.64(transitive)

• + Addedes6-iterator@2.0.3(transitive)

• + Addedes6-symbol@3.1.4(transitive)

• + Addedes6-weak-map@2.0.3(transitive)

• + Addedesniff@2.0.1(transitive)

• + Addedevent-emitter@0.3.5(transitive)

• + Addedext@1.7.0(transitive)

• + Addedis-promise@2.2.2(transitive)

• + Addedlru-queue@0.1.0(transitive)

• + Addedmemoizee@0.4.17(transitive)

• + Addednext-tick@1.1.0(transitive)

• + Addedtimers-ext@0.1.8(transitive)

• + Addedtype@2.7.3(transitive)