node-opcua-data-value - npm Package Compare versions

Comparing version 0.7.3 to 0.7.4

package.json

 {
  "name": "node-opcua-data-value",
  "main": "./index.js",
- "version": "0.7.3",
+ "version": "0.7.4",
  "description": "pure nodejs OPCUA SDK - module -data-value",
@@ -13,16 +13,16 @@ "scripts": {
   "node-opcua-assert": "^0.7.0",
-  "node-opcua-basic-types": "^0.7.3",
-  "node-opcua-binary-stream": "^0.7.3",
-  "node-opcua-date-time": "^0.7.3",
-  "node-opcua-factory": "^0.7.3",
-  "node-opcua-nodeid": "^0.7.2",
-  "node-opcua-status-code": "^0.7.3",
-  "node-opcua-utils": "^0.7.3",
-  "node-opcua-variant": "^0.7.3",
+  "node-opcua-basic-types": "^0.7.4",
+  "node-opcua-binary-stream": "^0.7.4",
+  "node-opcua-date-time": "^0.7.4",
+  "node-opcua-factory": "^0.7.4",
+  "node-opcua-nodeid": "^0.7.4",
+  "node-opcua-status-code": "^0.7.4",
+  "node-opcua-utils": "^0.7.4",
+  "node-opcua-variant": "^0.7.4",
   "underscore": "^1.9.1"
  },
  "devDependencies": {
-  "node-opcua-generator": "^0.7.3",
-  "node-opcua-numeric-range": "^0.7.3",
-  "node-opcua-packet-analyzer": "^0.7.3",
+  "node-opcua-generator": "^0.7.4",
+  "node-opcua-numeric-range": "^0.7.4",
+  "node-opcua-packet-analyzer": "^0.7.4",
   "should": "13.2.3"
@@ -45,3 +45,3 @@ },
  "homepage": "http://node-opcua.github.io/",
- "gitHead": "e7ed2b6dc6c717c8d42d0bbd07018414dfc00b6e"
+ "gitHead": "7a85ad8e37b709283fcfe19d93e39dc7e193633e"
 }

src/datavalue.js

@@ -11,2 +11,3 @@ "use strict";
 const VariantArrayType = require("node-opcua-variant").VariantArrayType;
+const StatusCodes = require("node-opcua-status-code").StatusCodes;
 
@@ -192,4 +193,8 @@
 
+    const statusCode = result.statusCode === StatusCodes.Good ? dataValue.statusCode : result.statusCode;
+
     const clonedDataValue = new DataValue({
-        statusCode: result.statusCode,
+
+        statusCode,
+
         serverTimestamp: dataValue.serverTimestamp,
@@ -196,0 +201,0 @@ serverPicoseconds: dataValue.serverPicoseconds,

test/test_datavalue.js

@@ -138,2 +138,40 @@ "use strict";
     });
+
+    it("DataValue - extractRange on a String with StatusCode != Good - issue #635", function () {
+
+        const dataValue = new DataValue({
+            statusCode: StatusCodes.BadCertificateHostNameInvalid,
+            value: new Variant({
+                dataType: DataType.String,
+                arrayType: VariantArrayType.Scalar,
+                value: "1234567890"
+            })
+        });
+        const dataValue1 = extractRange(dataValue, new NumericRange("2:3"));
+        dataValue1.value.value.length.should.eql(2);
+        dataValue1.value.value.should.eql("34");
+        dataValue1.value.dataType.should.eql(DataType.String);
+        dataValue1.value.arrayType.should.eql(VariantArrayType.Scalar);
+
+        dataValue1.statusCode.should.eql(StatusCodes.BadCertificateHostNameInvalid);
+    });
+    it("DataValue - extractRange on a String with StatusCode != Good and invalid range - issue #635", function () {
+
+        const dataValue = new DataValue({
+            statusCode: StatusCodes.BadCertificateHostNameInvalid,
+            value: new Variant({
+                dataType: DataType.String,
+                arrayType: VariantArrayType.Scalar,
+                value: "1234567890"
+            })
+        });
+        const dataValue1 = extractRange(dataValue, new NumericRange("20:30"));
+        dataValue1.value.value.length.should.eql(0);
+        dataValue1.value.value.should.eql("");
+        dataValue1.value.dataType.should.eql(DataType.String);
+        dataValue1.value.arrayType.should.eql(VariantArrayType.Scalar);
+
+        dataValue1.statusCode.should.eql(StatusCodes.BadIndexRangeNoData);
+    });
+
     it("DataValue - extractRange on a ByteString", function () {
@@ -140,0 +178,0 @@

No alert changes

Improved metrics

Total package byte prevSize

52512

increased by3.6%

Lines of code

1090

increased by3.22%

Dependency changes

• Updatednode-opcua-basic-types@^0.7.4

• Updatednode-opcua-binary-stream@^0.7.4

• Updatednode-opcua-date-time@^0.7.4

• Updatednode-opcua-factory@^0.7.4

• Updatednode-opcua-nodeid@^0.7.4

• Updatednode-opcua-status-code@^0.7.4

• Updatednode-opcua-utils@^0.7.4

• Updatednode-opcua-variant@^0.7.4