onscrolling
Advanced tools
Comparing version 2.0.0-beta.1 to 2.0.0-beta.2
@@ -20,3 +20,3 @@ import jsPlugin from '@eslint/js'; | ||
{ | ||
ignores: ['dist/', 'public/'], | ||
ignores: ['dist/', 'vitest.config.ts', 'public/'], | ||
}, | ||
@@ -23,0 +23,0 @@ |
{ | ||
"name": "onscrolling", | ||
"version": "2.0.0-beta.1", | ||
"version": "2.0.0-beta.2", | ||
"description": "A better, smoother, more performant window.onscroll event interface using requestAnimationFrame for performance and mobile-compatibility", | ||
@@ -5,0 +5,0 @@ "type": "module", |
@@ -1,3 +0,1 @@ | ||
'use strict'; | ||
// Module state | ||
@@ -151,6 +149,2 @@ let isListening = false; | ||
callbackQueue.x = callbackQueue.x.concat(callback); | ||
console.log( | ||
'adding listener, callbackQueue.x.length', | ||
callbackQueue.x.length, | ||
); | ||
} | ||
@@ -160,6 +154,2 @@ | ||
callbackQueue.y = callbackQueue.y.concat(callback); | ||
console.log( | ||
'adding listener, callbackQueue.y.length', | ||
callbackQueue.y.length, | ||
); | ||
} | ||
@@ -181,10 +171,3 @@ | ||
if (index > -1) { | ||
console.log('pre callbackQueue.x.length', callbackQueue.x.length); | ||
callbackQueue.x = callbackQueue.x.toSpliced(index, 1); | ||
console.log( | ||
'clean up horizontal; index', | ||
index, | ||
'callbackQueue.x.length', | ||
callbackQueue.x.length, | ||
); | ||
} | ||
@@ -196,10 +179,3 @@ } | ||
if (index > -1) { | ||
console.log('pre callbackQueue.y.length', callbackQueue.y.length); | ||
callbackQueue.y = callbackQueue.y.toSpliced(index, 1); | ||
console.log( | ||
'clean up vertical; index', | ||
index, | ||
'callbackQueue.y.length', | ||
callbackQueue.y.length, | ||
); | ||
} | ||
@@ -210,3 +186,2 @@ } | ||
if (!callbackQueue.x.length && !callbackQueue.y.length) { | ||
console.log('no listeners left'); | ||
cancelTick(); | ||
@@ -213,0 +188,0 @@ disableScrollListener(); |
@@ -37,3 +37,3 @@ import { Window } from 'happy-dom'; | ||
expect(onScrollFn.mock.calls.length).toBe(0); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(1); | ||
@@ -47,9 +47,8 @@ cleanup(); | ||
triggerScroll('x'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(0); | ||
triggerScroll('y'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(1); | ||
cleanup(); | ||
console.log('just called cleanup'); | ||
}); | ||
@@ -61,6 +60,6 @@ | ||
triggerScroll('x'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(0); | ||
triggerScroll('y'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(1); | ||
@@ -75,6 +74,6 @@ cleanup(); | ||
triggerScroll(); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(0); | ||
triggerScroll('x'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(1); | ||
@@ -89,3 +88,3 @@ cleanup(); | ||
triggerScroll('x'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(1); | ||
@@ -103,6 +102,6 @@ cleanup(); | ||
triggerScroll('x'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(1); | ||
triggerScroll('y'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(2); | ||
@@ -120,6 +119,6 @@ cleanup(); | ||
triggerScroll('any'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(1); | ||
triggerScroll('y'); | ||
await delay(16); | ||
await delay(0); | ||
expect(onScrollFn.mock.calls.length).toBe(2); | ||
@@ -145,3 +144,3 @@ cleanup(); | ||
triggerScroll(); | ||
await delay(16); | ||
await delay(0); | ||
expect(results).not.toBeNull(); | ||
@@ -161,3 +160,3 @@ expect(results!.scrollX === window.scrollX).toBe(true); | ||
triggerScroll('x'); | ||
await delay(16); | ||
await delay(0); | ||
expect(results).not.toBeNull(); | ||
@@ -164,0 +163,0 @@ expect(results!.scrollX === window.scrollX).toBe(true); |
Major refactor
Supply chain riskPackage has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.
Found 1 instance in 1 package
0
30539
479