react-now-you-see-me - npm Package Compare versions

Comparing version 1.5.6 to 1.5.7

lib/in-view.js

@@ -20,4 +20,6 @@ "use strict";
 
-function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {}; if (desc.get || desc.set) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj["default"] = obj; return newObj; } }
+function _getRequireWildcardCache() { if (typeof WeakMap !== "function") return null; var cache = new WeakMap(); _getRequireWildcardCache = function _getRequireWildcardCache() { return cache; }; return cache; }
 
+function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } var cache = _getRequireWildcardCache(); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; if (obj != null) { var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj["default"] = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+
 function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
@@ -76,4 +78,10 @@
     _defineProperty(_assertThisInitialized(_this), "checkIsInView", function () {
-      if (!_this.mounted) return;
-      if (_this.props.once && _this.state.hasUpdated) return;
+      if (!_this.mounted) {
+        return;
+      }
+
+      if (_this.props.once && _this.state.hasUpdated) {
+        return;
+      }
+
       var threshold = _this.props.threshold;
@@ -80,0 +88,0 @@

lib/in-view.test.js

@@ -13,4 +13,6 @@ "use strict";
 
-function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {}; if (desc.get || desc.set) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj["default"] = obj; return newObj; } }
+function _getRequireWildcardCache() { if (typeof WeakMap !== "function") return null; var cache = new WeakMap(); _getRequireWildcardCache = function _getRequireWildcardCache() { return cache; }; return cache; }
 
+function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } var cache = _getRequireWildcardCache(); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; if (obj != null) { var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj["default"] = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+
 function asyncGeneratorStep(gen, resolve, reject, _next, _throw, key, arg) { try { var info = gen[key](arg); var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { Promise.resolve(value).then(_next, _throw); } }
@@ -20,4 +22,6 @@
 
-function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; var ownKeys = Object.keys(source); if (typeof Object.getOwnPropertySymbols === 'function') { ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(source).filter(function (sym) { return Object.getOwnPropertyDescriptor(source, sym).enumerable; })); } ownKeys.forEach(function (key) { _defineProperty(target, key, source[key]); }); } return target; }
+function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); if (enumerableOnly) symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; }); keys.push.apply(keys, symbols); } return keys; }
 
+function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(source, true).forEach(function (key) { _defineProperty(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(source).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
+
 function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
@@ -271,3 +275,2 @@
         case 4:
-          // Should still be out of bounds.
           rerender({
@@ -319,3 +322,2 @@ debounce: 1,
         case 4:
-          // Should still be out of bounds.
           rerender({
@@ -367,3 +369,2 @@ debounce: 1,
         case 4:
-          // Now should be in-bounds.
           rerender({
@@ -451,3 +452,2 @@ debounce: 1,
         case 4:
-          // Now should be in-bounds.
           rerender({
@@ -454,0 +454,0 @@ isFullyContained: false

lib/util.js

@@ -15,6 +15,14 @@ "use strict";
     return function (fn) {
-      if (isFn(el.addEventListener)) el.addEventListener(evtName, fn, opts);
+      if (isFn(el.addEventListener)) {
+        el.addEventListener(evtName, fn, opts);
+      }
+
       return function () {
-        if (isFn(el.removeEventListener)) el.removeEventListener(evtName, fn);
-        if (isFn(fn.cancel)) fn.cancel();
+        if (isFn(el.removeEventListener)) {
+          el.removeEventListener(evtName, fn);
+        }
+
+        if (isFn(fn.cancel)) {
+          fn.cancel();
+        }
       };
@@ -58,4 +66,10 @@ };
   return function (element) {
-    if (!element) return false;
-    if (!element.offsetParent) return true;
+    if (!element) {
+      return false;
+    }
+
+    if (!element.offsetParent) {
+      return true;
+    }
+
     var horizMin = 0 - offsetHoriz;
@@ -62,0 +76,0 @@ var horizMax = window.innerWidth + offsetHoriz;

lib/util.test.js

@@ -21,3 +21,3 @@ "use strict";
 
-function _iterableToArrayLimit(arr, i) { var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
+function _iterableToArrayLimit(arr, i) { if (!(Symbol.iterator in Object(arr) || Object.prototype.toString.call(arr) === "[object Arguments]")) { return; } var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
 
@@ -95,28 +95,2 @@ function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
   });
-  it.skip('determins element to not be within threshold of view', function () {
-    expect((0, _util.inViewport)()(mockEl({
-      top: -500,
-      bottom: -401,
-      left: 500,
-      right: 500
-    }), undefined, 0.1)).toBe(false);
-    expect((0, _util.inViewport)()(mockEl({
-      top: 1500,
-      bottom: 1600,
-      left: 500,
-      right: 500
-    }), undefined, 0.1)).toBe(false);
-    expect((0, _util.inViewport)()(mockEl({
-      top: 500,
-      bottom: 600,
-      left: -500,
-      right: -400
-    }), undefined, 0.1)).toBe(false);
-    expect((0, _util.inViewport)()(mockEl({
-      top: 500,
-      bottom: 600,
-      left: 1500,
-      right: 1600
-    }), undefined, 0.1)).toBe(false);
-  });
 });
@@ -123,0 +97,0 @@ describe('on', function () {

package.json

 {
   "name": "react-now-you-see-me",
   "description": "A React component for determining when an element is within a given threshold of the viewport, horizontally.",
-  "version": "1.5.6",
+  "version": "1.5.7",
   "author": "Jane Web Team",
@@ -26,3 +26,2 @@ "contributors": [
     "prebuild": "run-s -s clean test:build",
-    "precommit": "sortpack && lint-staged",
     "preversion": "npm run build",
@@ -50,31 +49,33 @@ "test": "run-s -s test:lint test:jest",
   "devDependencies": {
-    "@babel/cli": "7.4.4",
-    "@babel/core": "7.4.4",
-    "@babel/plugin-proposal-class-properties": "7.4.4",
-    "@babel/preset-env": "7.4.4",
+    "@babel/cli": "7.6.0",
+    "@babel/core": "7.6.0",
+    "@babel/plugin-proposal-class-properties": "7.5.5",
+    "@babel/preset-env": "7.6.0",
     "@babel/preset-react": "7.0.0",
-    "@babel/register": "7.0.0",
+    "@babel/register": "7.6.0",
     "babel-core": "7.0.0-bridge.0",
-    "babel-eslint": "10.0.1",
-    "babel-jest": "23.6.0",
-    "babel-loader": "8.0.4",
-    "babel-plugin-transform-react-remove-prop-types": "0.4.18",
-    "coveralls": "3.0.2",
+    "babel-eslint": "10.0.3",
+    "babel-jest": "24.9.0",
+    "babel-loader": "8.0.6",
+    "babel-plugin-transform-react-remove-prop-types": "0.4.24",
+    "core-js": "3.2.1",
+    "coveralls": "3.0.6",
     "dom-testing-library": "2.5.0",
-    "eslint": "5.16.0",
-    "eslint-plugin-jane": "1.0.2",
-    "husky": "1.1.1",
-    "jest": "23.6.0",
-    "lint-staged": "7.3.0",
+    "eslint": "6.3.0",
+    "eslint-plugin-jane": "7.0.0",
+    "husky": "3.0.5",
+    "jest": "24.9.0",
+    "lint-staged": "9.2.5",
     "marked": "0.7.0",
     "npm-run-all": "4.1.5",
-    "prettier": "1.14.3",
-    "prop-types": "15.6.2",
+    "prettier": "1.18.2",
+    "prop-types": "15.7.2",
     "react": "16.5.2",
     "react-dom": "16.5.2",
     "react-testing-library": "5.2.0",
-    "sortpack": "1.1.5",
-    "webpack": "4.20.2",
-    "webpack-cli": "3.1.2",
-    "webpack-dev-server": "3.2.1"
+    "regenerator-runtime": "0.13.3",
+    "sortpack": "2.0.1",
+    "webpack": "4.40.0",
+    "webpack-cli": "3.3.8",
+    "webpack-dev-server": "3.8.0"
   },
@@ -116,3 +117,8 @@ "jest": {
     "react-dom": ">=16.0.0"
+  },
+  "husky": {
+    "hooks": {
+      "pre-commit": "sortpack && lint-staged"
+    }
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

38246

increased by1.78%

Worsened metrics

Dev dependency count

31

increased by6.9%

Lines of code

759

decreased by-1.3%

No dependency changes