react-three-renderer - npm Package Compare versions

Comparing version 0.0.10-alpha to 0.0.11-alpha

lib/React3Renderer.js

@@ -776,15 +776,10 @@ 'use strict';
 
-          childMarkup = null;
-
           if (ownerChildrenMarkups) {
-            // child = child.nextSibling;
-            for (var i = 0; i < ownerChildrenMarkups.length - 1; i++) {
-              var ownerChildId = this.getID(ownerChildrenMarkups[i]);
+            var indexInParent = ownerChildrenMarkups.indexOf(childMarkup);
 
-              if (ownerChildId === childID) {
-                // if the owner's child's id is the same as my id, then the next sibling markup is:
-                childMarkup = ownerChildrenMarkups[i + 1];
-                break;
-              }
-            }
+            (0, _fbjsLibInvariant2['default'])(indexInParent !== -1, 'Could not find child markup`s index in parent');
+
+            childMarkup = ownerChildrenMarkups.length > indexInParent && ownerChildrenMarkups[indexInParent + 1] || null;
+          } else {
+            childMarkup = null;
           }
@@ -791,0 +786,0 @@ }

package.json

 {
   "name": "react-three-renderer",
-  "version": "0.0.10-alpha",
+  "version": "0.0.11-alpha",
   "description": "Render into a three.js canvas using React.",
@@ -38,3 +38,5 @@ "main": "./lib/React3.js",
     "stage": 0,
-    "optional": ["runtime"]
+    "optional": [
+      "runtime"
+    ]
   },
@@ -41,0 +43,0 @@ "bugs": {

src/React3Renderer.js

@@ -573,15 +573,10 @@ import THREE from 'three.js';
 
-        childMarkup = null;
-
         if (ownerChildrenMarkups) {
-          // child = child.nextSibling;
-          for (let i = 0; i < ownerChildrenMarkups.length - 1; i++) {
-            const ownerChildId = this.getID(ownerChildrenMarkups[i]);
+          const indexInParent = ownerChildrenMarkups.indexOf(childMarkup);
 
-            if (ownerChildId === childID) {
-              // if the owner's child's id is the same as my id, then the next sibling markup is:
-              childMarkup = ownerChildrenMarkups[i + 1];
-              break;
-            }
-          }
+          invariant(indexInParent !== -1, 'Could not find child markup`s index in parent');
+
+          childMarkup = ownerChildrenMarkups.length > indexInParent && ownerChildrenMarkups[indexInParent + 1] || null;
+        } else {
+          childMarkup = null;
         }
@@ -588,0 +583,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

650799

decreased by-0.03%

Lines of code

15089

decreased by-0.07%

No dependency changes