react-tradeshift-ui - npm Package Compare versions

Comparing version 0.0.0-development to 0.0.0

.storybook/config.js

@@ -9,6 +9,2 @@ import { configure, setAddon, addDecorator } from '@kadira/storybook';
 
-function loadStories() {
-	require('../src/stories');
-}
-
 setOptions({
@@ -25,2 +21,4 @@ name: 'React-tradeshift-ui',
 
-configure(loadStories, module);
+configure(function loadStories() {
+	require('../src/stories');
+}, module);

package.json

 {
   "name": "react-tradeshift-ui",
-  "version": "0.0.0-development",
+  "version": "0.0.0",
   "main": "components/index.js",
@@ -13,3 +13,4 @@ "license": "MIT",
     "test": "react-scripts test --env=jsdom",
-    "semantic-release": "semantic-release pre && npm publish && semantic-release post"
+    "semantic-release": "semantic-release pre && npm publish && semantic-release post",
+    "commitmsg": "opt --in commit-msg --exec \"validate-commit-msg\""
   },
@@ -45,2 +46,3 @@ "lint-staged": {
     "lint-staged": "^3.4.1",
+    "opt-cli": "^1.5.1",
     "prettier": "^1.3.1",
@@ -54,2 +56,3 @@ "react": "^15.5.4",
   "dependencies": {
+    "classnames": "^2.2.5",
     "prop-types": "^15.5.8",
@@ -69,2 +72,2 @@ "react-portal": "^3.1.0"
   "homepage": "https://github.com/wejendorp/react-tradeshift-ui#readme"
-}
+}

README.md

 # react-tradeshift-ui
-React wrappers for the [Tradeshift ui components](https://github.com/tradeshift/tradeshift-ui)
+React wrappers for the [Tradeshift ui components](https://github.com/tradeshift/tradeshift-ui).
+Check the component storybook at [tradeshift.github.io/react-tradeshift-ui](https://wejendorp.github.io/react-tradeshift-ui).
 
@@ -10,5 +11,6 @@ [![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
 
+[![npm version](https://badge.fury.io/js/react-tradeshift-ui.svg)](https://badge.fury.io/js/react-tradeshift-ui)
 [![Build Status](https://travis-ci.org/wejendorp/react-tradeshift-ui.svg?branch=master)](https://travis-ci.org/wejendorp/react-tradeshift-ui)
 
-# installation
+## Installation
 
@@ -20,1 +22,21 @@ ```bash
 *Note:* Requires [Tradeshift ui](http://ui.tradeshift.com/#getstarted/) explicitly loaded on your page.
+
+## Development
+Development with minimal setup via [Storybook](https://github.com/storybooks/storybook) and
+[react-scripts](https://github.com/facebookincubator/create-react-app).
+
+```bash
+$ npm install
+$ npm start
+$ open http://localhost:9009
+```
+
+will open the Storybook with hot module reloading enabled.
+
+### Release
+Any code pushed to master will be automatically released to `npm` with an appropriate semantic version.
+Releases are handled automatically by Travis-CI via [semantic-release](https://github.com/semantic-release/semantic-release)
+and [commitizen](http://commitizen.github.io/cz-cli/) commit message conventions.
+
+## License
+MIT

src/components/Menu/index.js

@@ -1,1 +0,17 @@
-export default () => {};
+import React from 'react';
+import PropTypes from 'prop-types';
+
+const Menu = ({ children }) => <menu data-ts="Menu">{children}</menu>;
+
+Menu.propTypes = {
+	children: PropTypes.oneOfType([
+		PropTypes.arrayOf(PropTypes.node),
+		PropTypes.node
+	])
+};
+
+Menu.defaultProps = {
+	children: null
+};
+
+export default Menu;

src/stories/Aside.js

@@ -5,2 +5,4 @@ import React from 'react';
 import Aside from '../components/Aside';
+import Menu from '../components/Menu';
+import MenuItem from '../components/MenuItem';
 
@@ -23,3 +25,9 @@ const stories = storiesOf('Aside', module);
 			onClosed={action('onClosed')}
-		/>
+		>
+			<Menu>
+				<MenuItem>
+					Menu item
+				</MenuItem>
+			</Menu>
+		</Aside>
 	),
@@ -26,0 +34,0 @@ { inline: true }

No alert changes

Improved metrics

Total package byte prevSize

9947

increased by25.99%

Number of package files

15

increased by7.14%

Lines of code

187

increased by30.77%

Number of lines in readme file

41

increased by115.79%

Worsened metrics

Dependency count

4

increased by33.33%

Dev dependency count

23

increased by4.55%

Dependency changes

• + Addedclassnames@^2.2.5

• + Addedclassnames@2.5.1(transitive)