sao - npm Package Compare versions

Comparing version 0.21.0 to 0.21.1

CHANGELOG.md

@@ -0,1 +1,14 @@
+## [Version 0.21.1](https://github.com/egoist/sao/releases/tag/v0.21.1) (2017-8-4)
+
+### New features
+
+- add option to disable template update notifier: [`8550513`](https://github.com/egoist/sao/commit/8550513)
+
+### Bug fixes
+
+- tweaks: [`5bf21ba`](https://github.com/egoist/sao/commit/5bf21ba)
+- Do not install dependencies if repo does not have config file: [`7df56f1`](https://github.com/egoist/sao/commit/7df56f1)
+
+[...full changes](https://github.com/egoist/sao/compare/v0.21.0...v0.21.1)
+
 ## [Version 0.21.0](https://github.com/egoist/sao/releases/tag/v0.21.0) (2017-8-4)
@@ -2,0 +15,0 @@

lib/index.js

@@ -21,3 +21,3 @@ 'use strict'
     targetPath = './',
-    config: configFileName,
+    config: configFileName = 'sao.js',
     install,
@@ -27,3 +27,4 @@ removeStore,
     forceNpm,
-    clone
+    clone,
+    updateNotify
   } = {}
@@ -51,7 +52,10 @@ ) {
 
-      const pm = npmInstall.getPm({ respectNpm5: forceNpm })
-      log.info(
-        `Since this template is a git repo, we're installing its dependencies with ${pm} now.`
-      )
-      npmInstall({ cwd: dest, production: true, respectNpm5: forceNpm })
+      const repoHasConfig = yield pathExists(path.join(dest, configFileName))
+      if (repoHasConfig) {
+        const pm = npmInstall.getPm({ respectNpm5: forceNpm })
+        log.info(
+          `Since this template is a git repo, we're installing its dependencies with ${pm} now.`
+        )
+        npmInstall({ cwd: dest, production: true, respectNpm5: forceNpm })
+      }
     }
@@ -91,4 +95,6 @@ } else if (parsed.type === 'npm') {
 
-    // Run update notifier for package template
-    utils.updateNotify(require(path.join(dest, 'package.json')))
+    if (updateNotify) {
+      // Run update notifier for package template
+      utils.updateNotify(require(path.join(dest, 'package.json')))
+    }
   }
@@ -95,0 +101,0 @@

lib/mock-prompt.js

@@ -15,6 +15,5 @@ const os = require('os')
       write: false,
-      log: false,
-      skipStore: true
+      log: false
     })
   )
 }

lib/utils/config.js

@@ -6,2 +6,3 @@ 'use strict'
 const home = require('user-home')
+const pathExists = require('path-exists')
 
@@ -18,13 +19,7 @@ const configDir = path.join(home, '.sao')
 
-function getConfig(dir, configFileName) {
-  return new Promise((resolve, reject) => {
-    const configPath = path.join(dir, configFileName)
-    fs.exists(configPath, exists => {
-      if (!exists) return resolve(null)
-      try {
-        resolve(require(configPath))
-      } catch (err) {
-        reject(err)
-      }
-    })
+function getConfig(templateDir, configFileName) {
+  const configPath = path.join(templateDir, configFileName)
+  return pathExists(configPath).then(exists => {
+    if (!exists) return null
+    return require(configPath)
   })
@@ -31,0 +26,0 @@ }

package.json

 {
   "name": "sao",
-  "version": "0.21.0",
+  "version": "0.21.1",
   "description": "Futuristic project generator.",
@@ -5,0 +5,0 @@ "license": "MIT",

No alert changes

Improved metrics

Total package byte prevSize

34426

increased by2.1%

No dependency changes