scribe-editor - npm Package Compare versions

Comparing version 1.4.15 to 2.0.0

CHANGELOG.md

@@ -0,1 +1,7 @@
+# 2.0.0
+
+A split text node will [no longer be replaced by a non-breaking backspace](https://github.com/guardian/scribe/pull/421) but instead should be a regular space character.
+
+Thanks [Jeffrey Wear](https://github.com/wearhere) for this change/fix
+
 # 1.4.15
@@ -2,0 +8,0 @@

package.json

 {
   "name": "scribe-editor",
-  "version": "1.4.15",
+  "version": "2.0.0",
   "main": "src/scribe.js",
@@ -5,0 +5,0 @@ "dependencies": {

src/api/selection.js

@@ -141,3 +141,8 @@ define(function () {
       Array.prototype.forEach.call(this.getMarkers(), function (marker) {
+        var markerParent = marker.parentNode;
         nodeHelpers.removeNode(marker);
+        // Placing the markers may have split a text node. Sew it up, otherwise
+        // if the user presses space between the nodes the browser will insert
+        // an ` ` and that will cause word wrapping issues.
+        markerParent.normalize();
       });
@@ -144,0 +149,0 @@ };

No alert changes

Improved metrics

Total package byte prevSize

198498

increased by0.28%

Lines of code

4119

increased by0.12%

No dependency changes