scribe-editor - npm Package Compare versions

Comparing version 2.0.2 to 2.1.0

CHANGELOG.md

@@ -0,1 +1,7 @@
+# 2.1.0
+
+Changes the way the mutation observer is determined and changes the way that nodes with certain classes are checked for. Both of these changes are aimed at offerring better support for server-side rendering.
+
+Thank you [Sergey Zyablitsky](https://github.com/szyablitsky) and [Simon Degraeve](https://github.com/SimonDegraeve) for your contributions towards this goal.
+
 # 2.0.2
@@ -2,0 +8,0 @@

package.json

 {
   "name": "scribe-editor",
-  "version": "2.0.2",
+  "version": "2.1.0",
   "main": "src/scribe.js",
@@ -29,3 +29,4 @@ "dependencies": {
     "selenium-webdriver": "~2.41.0",
-    "sinon": "^1.12.2"
+    "sinon": "^1.12.2",
+    "mock-browser": "0.90.33"
   },
@@ -32,0 +33,0 @@ "scripts": {

src/dom-observer.js

 define([
-  './node'
-], function (nodeHelpers) {
+  './node',
+  './mutations'
+], function (nodeHelpers, mutations) {
 
-  var MutationObserver = window.MutationObserver ||
-    window.WebKitMutationObserver ||
-    window.MozMutationObserver;
+  var MutationObserver = mutations.determineMutationObserver(window);
 
@@ -9,0 +8,0 @@ function hasRealMutation(n) {

src/node.js

@@ -41,10 +41,20 @@ define([
 
+  function elementHasClass(Node, className) {
+    return function(node) {
+      return (node.nodeType === Node.ELEMENT_NODE && node.className === className)
+    }
+  }
+
   function isSelectionMarkerNode(node) {
-    return (node.nodeType === Node.ELEMENT_NODE && node.className === 'scribe-marker');
+    return elementHasClass(Node, 'scribe-marker')(node);
   }
 
   function isCaretPositionNode(node) {
-    return (node.nodeType === Node.ELEMENT_NODE && node.className === 'caret-position');
+    return elementHasClass(Node, 'caret-position')(node);
   }
 
+  function isNotObservableNode(node) {
+    return elementHasClass(Node, 'scribe-not-observable')(node);
+  }
+
   function firstDeepestChild(node) {
@@ -163,5 +173,6 @@ var fs = node.firstChild;
     unwrap: unwrap,
-    removeChromeArtifacts: removeChromeArtifacts
+    removeChromeArtifacts: removeChromeArtifacts,
+    elementHasClass: elementHasClass
   };
 
 });

No alert changes

Improved metrics

Total package byte prevSize

202805

increased by1.77%

Number of package files

80

increased by3.9%

Lines of code

4211

increased by2.26%

Worsened metrics

Dev dependency count

21

increased by5%

No dependency changes