sharedb - npm Package Compare versions

Comparing version 0.11.22 to 0.11.23

package.json

 {
   "name": "sharedb",
-  "version": "0.11.22",
+  "version": "0.11.23",
   "description": "JSON OT database backend",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

test/client/submit.js

@@ -689,11 +689,28 @@ var async = require('async');
 
-  it('fetch does not revert version of doc with final pending delete', function(done) {
+  it('snapshot fetch does not revert the version of deleted doc without pending ops', function(done) {
+    var doc = this.backend.connect().get('dogs', 'fido');
     this.backend.use('doc', function(request, next) {
-      setTimeout(next, 10);
+      doc.create({age: 3});
+      doc.del(next);
     });
+    doc.fetch(function(err) {
+      if (err) return done(err);
+      expect(doc.version).equal(2);
+      done();
+    });
+  });
+
+  it('snapshot fetch does not revert the version of deleted doc with pending ops', function(done) {
     var doc = this.backend.connect().get('dogs', 'fido');
-    async.parallel([
-      function(cb) { doc.fetch(cb); },
-      function(cb) { doc.create({age: 3}, cb); }
-    ], function(err) {
+    this.backend.use('doc', function(request, next) {
+      doc.create({age: 3}, function(err) {
+        if (err) return done(err);
+        next();
+      });
+      process.nextTick(function() {
+        doc.pause();
+        doc.del(done);
+      });
+    });
+    doc.fetch(function(err) {
       if (err) return done(err);
@@ -703,5 +720,34 @@ expect(doc.version).equal(1);
     });
+  });
+
+  it('snapshot fetch from query does not advance version of doc with pending ops', function(done) {
+    var doc = this.backend.connect().get('dogs', 'fido');
+    var doc2 = this.backend.connect().get('dogs', 'fido');
+    doc.create({name: 'kido'}, function(err) {
+      if (err) return done(err);
+      doc2.fetch(function(err) {
+        if (err) return done(err);
+        doc2.submitOp({p: ['name', 0], si: 'f'}, function(err) {
+          if (err) return done(err);
+          expect(doc2.data).eql({name: 'fkido'});
+          doc.connection.createFetchQuery('dogs', {}, null, function(err) {
+            if (err) return done(err);
+            doc.resume();
+          });
+        });
+      });
+    });
     process.nextTick(function() {
       doc.pause();
-      doc.del(done);
+      doc.submitOp({p: ['name', 0], sd: 'k'}, function(err) {
+        if (err) return done(err);
+        doc.pause();
+        doc2.fetch(function(err) {
+          if (err) return done(err);
+          expect(doc2.version).equal(3);
+          expect(doc2.data).eql({name: 'fido'});
+          done();
+        });
+      });
+      doc.del();
     });
@@ -708,0 +754,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

278042

increased by0.54%

Lines of code

7344

increased by0.6%

No dependency changes