telnyx - npm Package Compare versions

Comparing version 1.2.3 to 1.2.4

CHANGELOG.md

 # CHANGELOG
 
+#### v1.2.4 (2019-10-22)
+
+##### Bug Fixes
+
+* **resources:** fix content-length header calculation on requestData
+  * account for multi-byte chars on getting request data length (e.g.: `en dash`)
+  * improve specs
+
 #### v1.2.3 (2019-9-25)
@@ -4,0 +12,0 @@

lib/TelnyxResource.js

@@ -9,2 +9,3 @@ 'use strict';
 var Error = require('./Error');
+var Buffer = require('safe-buffer').Buffer;
 
@@ -300,3 +301,3 @@ var hasOwn = {}.hasOwnProperty;
 
-  _defaultHeaders: function(auth, contentLength) {
+  _defaultHeaders: function(auth, requestData) {
     var userAgentString = 'Telnyx/v1 NodeBindings/' + this._telnyx.getConstant('PACKAGE_VERSION');
@@ -315,3 +316,3 @@
       'Content-Type': 'application/json',
-      'Content-Length': contentLength,
+      'Content-Length': Buffer.byteLength(requestData),
       'User-Agent': userAgentString,
@@ -345,3 +346,3 @@ };
 
-      headers = self._defaultHeaders(auth, requestData.length);
+      headers = self._defaultHeaders(auth, requestData);
       self._telnyx.getClientUserAgent(function(cua) {
@@ -361,7 +362,7 @@ headers['X-Telnyx-Client-User-Agent'] = cua;
     } else if (method == 'GET') {
-      makeRequestWithData(null, utils.stringifyRequestData(data || {}));
+      makeRequestWithData(null, data ? utils.stringifyRequestData(data) : '');
     } else if (method == 'DELETE') {
       makeRequestWithData(null, '');
     } else {
-      makeRequestWithData(null, JSON.stringify(data || {}));
+      makeRequestWithData(null, data ? JSON.stringify(data) : '');
     }
@@ -368,0 +369,0 @@

package.json

 {
   "name": "telnyx",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "Telnyx API Node SDK",
@@ -5,0 +5,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

73351

increased by0.38%

Lines of code

1774

increased by0.06%

No dependency changes