terra-slide-panel-manager - npm Package Compare versions

Comparing version 5.52.0 to 5.53.0

CHANGELOG.md

@@ -5,2 +5,7 @@ # Changelog
 
+## 5.53.0 - (May 4, 2021)
+
+* Removed
+  * Removed the onMaximize and onMinimize defaulted implementation to prevent usability risk
+
 ## 5.52.0 - (April 6, 2021)
@@ -7,0 +12,0 @@

lib/SlidePanelManager.js

@@ -5,3 +5,3 @@ "use strict";
 
-var _interopRequireWildcard = require("@babel/runtime/helpers/interopRequireWildcard");
+var _typeof = require("@babel/runtime/helpers/typeof");
 
@@ -47,2 +47,6 @@ Object.defineProperty(exports, "__esModule", {
 
+function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
+
+function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
@@ -148,5 +152,3 @@
             onClose: manager.closeDisclosure,
-            onBack: manager.disclosureComponentKeys.length > 1 ? manager.dismissPresentedComponent : undefined,
-            onMaximize: manager.maximizeDisclosure,
-            onMinimize: manager.minimizeDisclosure
+            onBack: manager.disclosureComponentKeys.length > 1 ? manager.dismissPresentedComponent : undefined
           }, headerDataForPresentedComponent.collapsibleMenuView) : undefined, disclosureAccessory)
@@ -153,0 +155,0 @@ }, /*#__PURE__*/_react.default.createElement(_terraSlideGroup.default, {

package.json

 {
   "name": "terra-slide-panel-manager",
   "main": "lib/SlidePanelManager.js",
-  "version": "5.52.0",
+  "version": "5.53.0",
   "description": "A DisclosureManager implementation that presents disclosed content using a SlidePanel.",
@@ -40,3 +40,3 @@ "repository": {
   "devDependencies": {
-    "terra-collapsible-menu-view": "^6.51.0"
+    "terra-collapsible-menu-view": "^6.52.0"
   },
@@ -56,3 +56,3 @@ "scripts": {
   },
-  "gitHead": "1fa6d8cf63b0e669846ff5bc3b085a95058c029e"
+  "gitHead": "6afbc5f45b0c8cd62c9a755cf75eb252d58d687f"
 }

src/SlidePanelManager.jsx

@@ -104,4 +104,2 @@ import React from 'react';
                     onBack={manager.disclosureComponentKeys.length > 1 ? manager.dismissPresentedComponent : undefined}
-                    onMaximize={manager.maximizeDisclosure}
-                    onMinimize={manager.minimizeDisclosure}
                   >
@@ -108,0 +106,0 @@ {headerDataForPresentedComponent.collapsibleMenuView}

tests/wdio/slide-panel-manager-spec.js

@@ -254,56 +254,2 @@ Terra.describeViewports('SlidePanelManager', ['tiny', 'large'], () => {
   });
-
-  describe('Disclosure - Header Maximize', () => {
-    before(() => {
-      browser.url('/#/raw/tests/terra-slide-panel-manager/slide-panel-manager/slide-panel-manager-with-header-adapter');
-      browser.refresh();
-    });
-
-    afterEach(() => {
-      $('[class*="right-buttons"] > *:first-child').click();
-    });
-
-    it('presents the maximize button within the managed header', () => {
-      $('#root-component .disclose-large').click();
-
-      $('[class*="left-buttons"] > *:first-child').waitForDisplayed({ timeout: 500 });
-      Terra.validates.element('maximize button', { selector });
-    });
-
-    it('maximizes the disclosure when the maximize button is pressed', () => {
-      $('#root-component .disclose-large').click();
-
-      $('[class*="left-buttons"] > *:first-child').waitForDisplayed({ timeout: 500 });
-      $('[class*="left-buttons"] > *:first-child').click();
-      Terra.validates.element('after selecting maximize', { selector });
-    });
-  });
-
-  describe('Disclosure - Header Minimize', () => {
-    before(() => {
-      browser.url('/#/raw/tests/terra-slide-panel-manager/slide-panel-manager/slide-panel-manager-with-header-adapter');
-      browser.refresh();
-    });
-
-    afterEach(() => {
-      $('[class*="right-buttons"] > *:first-child').click();
-    });
-
-    it('presents the minimize button within the managed header', () => {
-      $('#root-component .disclose-large').click();
-
-      $('[class*="left-buttons"] > *:first-child').waitForDisplayed({ timeout: 500 });
-      $('[class*="left-buttons"] > *:first-child').click();
-      Terra.validates.element('minimize button', { selector });
-    });
-
-    it('maximizes the disclosure when the minimize button is pressed', () => {
-      $('#root-component .disclose-large').click();
-
-      $('[class*="left-buttons"] > *:first-child').waitForDisplayed({ timeout: 500 });
-      $('[class*="left-buttons"] > *:first-child').click();
-      $('[class*="left-buttons"] > *:first-child').click();
-      Terra.validates.element('after selecting minimize', { selector });
-    });
-  });
 });
@@ -310,0 +256,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

163499

decreased by-0.66%

Lines of code

2766

decreased by-1.46%

No dependency changes