testarmada-magellan-nightwatch - npm Package Compare versions

Comparing version 2.0.1 to 3.0.0

lib/base-test-class.js

@@ -6,3 +6,3 @@ // Base test class that should be used for all Magellan tests
 var sauce = require("./util/sauce"),
-  magellanAPI = require("./client-api"),
+  SessionAcquisitionWrapper = require("./selenium-session-acquisition-wrapper"),
   clc = require("cli-color"),
@@ -12,34 +12,2 @@ Q = require("q"),
 
-var logUncaughtBrowserErrors = function (browserErrors) {
-
-  var deferred = Q.defer();
-
-  if (browserErrors.length > 0) {
-    console.log(clc.yellowBright("\n\u2622  Uncaught browser errors detected:"));
-
-    browserErrors.forEach(function(err, N){
-      var msg = err.message != "" ? (" : " + err.message) : "";
-      console.log(clc.yellowBright("\n" + (N + 1) + ") @ " + err.time + msg));
-
-      if (err.name !== "") {
-        console.log(clc.yellowBright("      name:", err.name));
-      }
-
-      if (err.filename !== "") {
-        console.log(clc.yellowBright("  filename:", err.filename));
-      }
-
-      console.log(clc.yellowBright("      line:", err.line));
-      console.log(clc.yellowBright("    column:", err.column));
-
-      if (err.stack) {
-        console.log(clc.yellowBright("     stack:", err.stack));
-      }
-    });
-  }
-
-  deferred.resolve();
-  return deferred.promise;
-};
-
 var closeSession = function(client) {
@@ -80,3 +48,3 @@
 
-var emitFinishedTest = function(client, numFailures, browserErrors) {
+var emitFinishedTest = function(client, numFailures) {
 
@@ -92,3 +60,5 @@ if (settings.isWorker === true) {
         resultURL: sauce.getTestUrl(client),
-        browserErrors: browserErrors
+        // Note: browserErrors has been deprecated, but we don't want to regress
+        // versions of magellan that consume this property, so we pass it along.
+        browserErrors: []
       }
@@ -107,4 +77,4 @@ });
 
-  // Proxy Magellan commands destined for Nightwatch API
-  magellanAPI.initialize(this, steps);
+  // Add step wrapper to capture selenium session id
+  SessionAcquisitionWrapper.initialize(this, steps);
 
@@ -126,4 +96,2 @@ // copy incoming steps onto self
   });
-
-  Object.defineProperty(this, "browserErrors", { enumerable: false, value: [] });
 };
@@ -199,6 +167,3 @@
 
-    logUncaughtBrowserErrors(self.browserErrors)
-      .then(function() {
-        return emitFinishedTest(client, numFailures, self.browserErrors);
-      })
+    emitFinishedTest(client, numFailures)
       .then(function() { return updateSauceStats(client, numFailures); })
@@ -205,0 +170,0 @@ .then(function() { return closeSession(client); })

package.json

 {
   "name": "testarmada-magellan-nightwatch",
-  "version": "2.0.1",
+  "version": "3.0.0",
   "description": "Nightwatch.js adapter for Magellan",
@@ -80,11 +80,7 @@ "main": "index.js",
     "jsonfile": "2.0.0",
-    "lodash": "2.4.1",
-    "methodmissing": "0.0.3",
     "phantomjs": "1.9.18",
     "q": "1.0.1",
-    "qs": "2.2.4",
     "request": "2.40.0",
     "sanitize-filename": "1.3.0",
     "selenium-server": "2.46.0",
-    "send": "0.10.1",
     "yargs": "1.3.2"
@@ -91,0 +87,0 @@ },

No alert changes

Improved metrics

Dependency count

10

decreased by-28.57%

Number of low supply chain risk alerts

3

decreased by-25%

Worsened metrics

Total package byte prevSize

177939

decreased by-3.41%

Number of package files

35

decreased by-5.41%

Lines of code

1806

decreased by-8.97%

Dependency changes

• - Removedlodash@2.4.1

• - Removedmethodmissing@0.0.3

• - Removedqs@2.2.4

• - Removedsend@0.10.1

• - Removedbindings@1.5.0(transitive)

• - Removedcrc@3.2.1(transitive)

• - Removeddebug@2.1.3(transitive)

• - Removeddepd@1.0.1(transitive)

• - Removeddestroy@1.0.3(transitive)

• - Removedee-first@1.1.0(transitive)

• - Removedescape-html@1.0.1(transitive)

• - Removedetag@1.5.1(transitive)

• - Removedfile-uri-to-path@1.0.0(transitive)

• - Removedfresh@0.2.4(transitive)

• - Removedlodash@2.4.1(transitive)

• - Removedmethodmissing@0.0.3(transitive)

• - Removedms@0.6.20.7.0(transitive)

• - Removednan@2.22.2(transitive)

• - Removednode-proxy@1.0.0(transitive)

• - Removedon-finished@2.1.1(transitive)

• - Removedqs@2.2.4(transitive)

• - Removedrange-parser@1.0.3(transitive)

• - Removedsend@0.10.1(transitive)