victory-scatter - npm Package Compare versions

Comparing version 37.3.2 to 37.3.3

CHANGELOG.md

 # victory-scatter
 
+## 37.3.3
+
+### Patch Changes
+
+- Improve types in victory-core helpers ([#2999](https://github.com/FormidableLabs/victory/pull/2999))
+
 ## 37.3.2
@@ -4,0 +10,0 @@

es/helper-methods.js

@@ -19,3 +19,3 @@ import { Helpers, LabelHelpers, Data, Domain, Scale } from "victory-core";
   const getMaxRadius = () => {
-    const minPadding = Math.min(...Object.values(Helpers.getPadding(props)));
+    const minPadding = Math.min(...Object.values(Helpers.getPadding(props.padding)));
     return Math.max(minPadding, 5); // eslint-disable-line no-magic-numbers
@@ -22,0 +22,0 @@ };

es/victory-scatter.d.ts

 import React from "react";
 import { Data, Domain, EventPropTypeInterface, ScatterSymbolType, StringOrNumberOrCallback, EventsMixinClass, VictoryCommonProps, VictoryDatableProps, VictoryMultiLabelableProps, VictoryStyleInterface } from "victory-core";
-export declare type VictoryScatterTTargetType = "data" | "labels" | "parent";
+export type VictoryScatterTTargetType = "data" | "labels" | "parent";
 export interface VictoryScatterProps extends VictoryCommonProps, VictoryDatableProps, VictoryMultiLabelableProps {
@@ -64,5 +64,5 @@ bubbleProperty?: string;
         renderContainer(component: any, children: any): React.DetailedReactHTMLElement<any, HTMLElement>;
-        animateComponent(props: import("victory-core").EventMixinCommonProps, defaultAnimationWhitelist: string[]): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+        animateComponent(props: import("victory-core").EventMixinCommonProps, defaultAnimationWhitelist: string[]): React.ReactElement;
         renderContinuousData(props: import("victory-core").EventMixinCommonProps): React.DetailedReactHTMLElement<any, HTMLElement>;
-        renderData(props: any, shouldRenderDatum?: ((datum: any) => boolean) | undefined): React.DetailedReactHTMLElement<any, HTMLElement>;
+        renderData(props: any, shouldRenderDatum?: (datum: any) => boolean): React.DetailedReactHTMLElement<any, HTMLElement>;
         context: unknown;
@@ -84,3 +84,3 @@ setState<K extends never>(state: {} | ((prevState: Readonly<{}>, props: Readonly<import("victory-core").EventMixinCommonProps>) => {} | Pick<{}, K> | null) | Pick<{}, K> | null, callback?: (() => void) | undefined): void;
         UNSAFE_componentWillUpdate?(nextProps: Readonly<import("victory-core").EventMixinCommonProps>, nextState: Readonly<{}>, nextContext: any): void;
-        componentEvents: import("@/victory-core/lib/victory-util/events").ComponentEvent[];
+        componentEvents: Array<import("@/victory-core/lib/victory-util/events").ComponentEvent>;
         getSharedEventState: (key: string, value: string) => unknown;
@@ -92,6 +92,6 @@ baseProps: Record<string, object>;
     };
-    getBaseProps?(props: import("victory-core").EventMixinCommonProps): Record<string, object>;
-    role?: string | undefined;
+    getBaseProps?(props: import("victory-core").EventMixinCommonProps): import("victory-core").EventMixinCalculatedValues["baseProps"];
+    role?: import("victory-core").VictoryComponentRole;
     expectedComponents?: string[] | undefined;
-    getChildren?: ((props: import("victory-core").EventMixinCommonProps, childComponents?: React.ReactNode[] | undefined, calculatedProps?: import("victory-core").EventMixinCommonProps | undefined) => void) | undefined;
+    getChildren?: ((props: import("victory-core").EventMixinCommonProps, childComponents?: Array<React.ReactNode>, calculatedProps?: import("victory-core").EventMixinCommonProps | undefined) => void) | undefined;
     animationWhitelist?: string[] | undefined;
@@ -98,0 +98,0 @@ } & typeof VictoryScatterBase;

lib/helper-methods.js

@@ -26,3 +26,3 @@ "use strict";
   const getMaxRadius = () => {
-    const minPadding = Math.min(...Object.values(_victoryCore.Helpers.getPadding(props)));
+    const minPadding = Math.min(...Object.values(_victoryCore.Helpers.getPadding(props.padding)));
     return Math.max(minPadding, 5); // eslint-disable-line no-magic-numbers
@@ -29,0 +29,0 @@ };

lib/victory-scatter.d.ts

 import React from "react";
 import { Data, Domain, EventPropTypeInterface, ScatterSymbolType, StringOrNumberOrCallback, EventsMixinClass, VictoryCommonProps, VictoryDatableProps, VictoryMultiLabelableProps, VictoryStyleInterface } from "victory-core";
-export declare type VictoryScatterTTargetType = "data" | "labels" | "parent";
+export type VictoryScatterTTargetType = "data" | "labels" | "parent";
 export interface VictoryScatterProps extends VictoryCommonProps, VictoryDatableProps, VictoryMultiLabelableProps {
@@ -64,5 +64,5 @@ bubbleProperty?: string;
         renderContainer(component: any, children: any): React.DetailedReactHTMLElement<any, HTMLElement>;
-        animateComponent(props: import("victory-core").EventMixinCommonProps, defaultAnimationWhitelist: string[]): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+        animateComponent(props: import("victory-core").EventMixinCommonProps, defaultAnimationWhitelist: string[]): React.ReactElement;
         renderContinuousData(props: import("victory-core").EventMixinCommonProps): React.DetailedReactHTMLElement<any, HTMLElement>;
-        renderData(props: any, shouldRenderDatum?: ((datum: any) => boolean) | undefined): React.DetailedReactHTMLElement<any, HTMLElement>;
+        renderData(props: any, shouldRenderDatum?: (datum: any) => boolean): React.DetailedReactHTMLElement<any, HTMLElement>;
         context: unknown;
@@ -84,3 +84,3 @@ setState<K extends never>(state: {} | ((prevState: Readonly<{}>, props: Readonly<import("victory-core").EventMixinCommonProps>) => {} | Pick<{}, K> | null) | Pick<{}, K> | null, callback?: (() => void) | undefined): void;
         UNSAFE_componentWillUpdate?(nextProps: Readonly<import("victory-core").EventMixinCommonProps>, nextState: Readonly<{}>, nextContext: any): void;
-        componentEvents: import("@/victory-core/lib/victory-util/events").ComponentEvent[];
+        componentEvents: Array<import("@/victory-core/lib/victory-util/events").ComponentEvent>;
         getSharedEventState: (key: string, value: string) => unknown;
@@ -92,6 +92,6 @@ baseProps: Record<string, object>;
     };
-    getBaseProps?(props: import("victory-core").EventMixinCommonProps): Record<string, object>;
-    role?: string | undefined;
+    getBaseProps?(props: import("victory-core").EventMixinCommonProps): import("victory-core").EventMixinCalculatedValues["baseProps"];
+    role?: import("victory-core").VictoryComponentRole;
     expectedComponents?: string[] | undefined;
-    getChildren?: ((props: import("victory-core").EventMixinCommonProps, childComponents?: React.ReactNode[] | undefined, calculatedProps?: import("victory-core").EventMixinCommonProps | undefined) => void) | undefined;
+    getChildren?: ((props: import("victory-core").EventMixinCommonProps, childComponents?: Array<React.ReactNode>, calculatedProps?: import("victory-core").EventMixinCommonProps | undefined) => void) | undefined;
     animationWhitelist?: string[] | undefined;
@@ -98,0 +98,0 @@ } & typeof VictoryScatterBase;

package.json

 {
   "name": "victory-scatter",
-  "version": "37.3.2",
+  "version": "37.3.3",
   "description": "Scatter Component for Victory",
@@ -24,3 +24,3 @@ "keywords": [
     "lodash": "^4.17.19",
-    "victory-core": "37.3.2"
+    "victory-core": "37.3.3"
   },
@@ -184,28 +184,2 @@ "peerDependencies": {
     },
-    "format": {
-      "command": "nps format:pkg",
-      "files": [
-        "src/**",
-        "*.json",
-        "../../.prettierignore",
-        "../../.prettierrc.json"
-      ],
-      "output": [],
-      "packageLocks": [
-        "pnpm-lock.yaml"
-      ]
-    },
-    "format:fix": {
-      "command": "pnpm run format || nps format:pkg:fix",
-      "files": [
-        "src/**",
-        "*.json",
-        "../../.prettierignore",
-        "../../.prettierrc.json"
-      ],
-      "output": [],
-      "packageLocks": [
-        "pnpm-lock.yaml"
-      ]
-    },
     "lint": {
@@ -273,4 +247,2 @@ "command": "eslint src",
     "types:create": "wireit",
-    "format": "wireit",
-    "format:fix": "wireit",
     "lint": "wireit",
@@ -277,0 +249,0 @@ "lint:fix": "wireit",

No alert changes

Improved metrics

Total package byte prevSize

979552

increased by0.06%

Lines of code

17563

increased by0.22%

Dependency changes

• + Addedvictory-core@37.3.3(transitive)

• + Addedvictory-vendor@37.3.3(transitive)

• - Removedvictory-core@37.3.2(transitive)

• - Removedvictory-vendor@37.3.2(transitive)

• Updatedvictory-core@37.3.3