zookeeper-hd - npm Package Compare versions

Comparing version 0.2.1 to 0.2.2

CHANGES.md

@@ -19,2 +19,3 @@ Changes
         - renamed createPathIfNotExist to createPathIfNotExists (old method redirects)
+        - removed logging from library, included example how to enable logging using scarletjs
     - SimpleClient
@@ -21,0 +22,0 @@ - added joinPath (also exposed by PlusClient)

js/src/lib/PlusClient.js

 // This file has been generated from coffee source files
 
-var DummyLogger, PlusClient, SimpleClient, async, _;
+var PlusClient, SimpleClient, async, _;
 
@@ -11,17 +11,5 @@ SimpleClient = require('./SimpleClient');
 
-DummyLogger = (function() {
-  function DummyLogger() {}
-
-  DummyLogger.prototype.info = function() {};
-
-  DummyLogger.prototype.debug = function() {};
-
-  return DummyLogger;
-
-})();
-
 module.exports = PlusClient = (function() {
   function PlusClient(options) {
     this.client = new SimpleClient(options);
-    this.log = options.logger || new DummyLogger();
   }
@@ -35,3 +23,2 @@
     if (!onReady) {
-      this.log.debug('create: no onReady argument, inserting empty options');
       onReady = options;
@@ -41,3 +28,2 @@ options = {};
     if (!_.isObject(options)) {
-      this.log.debug('create: non object options, moving it to options.flags');
       options = {
@@ -55,3 +41,2 @@ flags: options
     if (!onData) {
-      this.log.debug('exists: no onData argument, inserting empty options');
       onData = options;
@@ -61,3 +46,2 @@ options = {};
     if (!_.isObject(options)) {
-      this.log.debug('exists: non object options, moving it to options.watch');
       options = {
@@ -76,3 +60,2 @@ watch: options
     if (!onData) {
-      this.log.debug('get: no onData argument, inserting empty options');
       onData = options;
@@ -82,3 +65,2 @@ options = {};
     if (!_.isObject(options)) {
-      this.log.debug('get: non object options, moving it to options.watch');
       options = {
@@ -109,3 +91,2 @@ watch: options
     if (!onData) {
-      this.log.debug('getChildren: no onData argument, inserting empty options');
       onData = options;
@@ -115,3 +96,2 @@ options = {};
     if (!_.isObject(options)) {
-      this.log.debug('getChildren: non object options, moving it to options.watch');
       options = {
@@ -184,3 +164,2 @@ watch: options
     if (!onReady) {
-      this.log.debug('mkdir: no onReady argument, inserting empty options');
       onReady = options;
@@ -194,3 +173,2 @@ options = {};
     if (!onReady) {
-      this.log.debug('set: no onReady argument, inserting empty options');
       onReady = options;
@@ -204,7 +182,5 @@ options = {};
     if (!onReady) {
-      this.log.debug('createPathIfNotExist: no onReady argument, inserting empty options');
       onReady = options;
       options = {};
     }
-    this.log.info("createPathIfNotExists " + zkPath);
     return this.mkdir(zkPath, options, onReady);
@@ -214,3 +190,2 @@ };
   PlusClient.prototype.createPathIfNotExist = function(zkPath, options, onReady) {
-    this.log.info('createPathIfNotExist deprecated - use createPathIfNotExists instead');
     return createPathIfNotExists(zkPath, options, onReady);
@@ -222,3 +197,2 @@ };
     if (!onReady) {
-      this.log.debug('createOrUpdate: no onReady argument, inserting empty options');
       onReady = options;
@@ -228,3 +202,2 @@ options = {};
     if (!_.isObject(options)) {
-      this.log.debug('createOrUpdate: non object options, moving it to options.flags; onReady -> options.watch, onReady = arguments[4]');
       options = {
@@ -240,3 +213,2 @@ flags: options,
     });
-    this.log.info("#createOrUpdate " + value + " @ " + zkPath);
     return this.exists(zkPath, options, function(err, exists, stat) {
@@ -243,0 +215,0 @@ if (err) {

package.json

 {
   "name": "zookeeper-hd",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "Higher level (normalized) zookeeper client",
@@ -5,0 +5,0 @@ "author": "Hans Donner",

No alert changes

Worsened metrics

Total package byte prevSize

171701

decreased by-1.91%

Lines of code

1198

decreased by-1.88%

No dependency changes