ember-cli-deploy-webhooks - npm Package Compare versions

Comparing version 0.4.2 to 1.0.0-beta.1

config/environment.js

@@ -1,2 +0,1 @@
-/*jshint node:true*/
 'use strict';
@@ -3,0 +2,0 @@

lib/notify.js

@@ -1,8 +0,6 @@
-var RSVP       = require('rsvp');
-var CoreObject = require('core-object');
-var request    = require('request');
-var merge      = require('lodash/object/merge');
+const RSVP = require('rsvp');
+const CoreObject = require('core-object');
+const request = require('request');
+const merge = require('lodash/object/merge');
 
-var post = RSVP.denodeify(request.post);
-
 function optsValid(opts) {
@@ -13,3 +11,3 @@ return opts.url && opts.headers && opts.method && opts.body;
 module.exports = CoreObject.extend({
-  init: function(options) {
+  init(options) {
     this._plugin = options.plugin;
@@ -20,3 +18,3 @@
 
-  _defaults: function() {
+  _defaults() {
     return {
@@ -26,12 +24,11 @@ method: 'POST',
       json: true
-    }
+    };
   },
 
-  send: function(serviceKey, opts) {
-    var opts        = opts || {};
-    var plugin      = this._plugin;
-    var makeRequest = RSVP.denodeify(this._client);
-    var critical = (('critical' in opts) ? delete opts.critical : false);
+  send(serviceKey, opts = {}) {
+    let plugin = this._plugin;
+    let makeRequest = RSVP.denodeify(this._client);
+    let critical = (('critical' in opts) ? delete opts.critical : false);
 
-    var requestOpts = merge(this._defaults(), opts);
+    let requestOpts = merge(this._defaults(), opts);
 
@@ -41,3 +38,3 @@ if (optsValid(requestOpts)) {
         .then(function(response) {
-          var body = '';
+          let body = '';
 
@@ -52,10 +49,10 @@ if (response && response.body) {
 
-          if (critical && !(300 > response.statusCode && response.statusCode >= 200)) {
+          if (critical && !(response.statusCode < 300 && response.statusCode >= 200)) {
             return RSVP.reject(response.statusCode);
           }
 
-          plugin.log(serviceKey + ' => ' + body);
-        }.bind(this))
+          plugin.log(`${serviceKey} => ${body}`);
+        })
         .catch(function(error) {
-          var errorMessage = serviceKey + ' => ' + error;
+          let errorMessage = `${serviceKey} => ${error}`;
 
@@ -68,3 +65,3 @@ if (critical) {
     } else {
-      var warningMessage = 'No request issued! Request options invalid! You have to specify `url`, `headers`, `method` and `body`.';
+      let warningMessage = 'No request issued! Request options invalid! You have to specify `url`, `headers`, `method` and `body`.';
 
@@ -74,3 +71,3 @@ if (critical) {
       }
-      plugin.log(serviceKey+' => '+warningMessage, { color: 'yellow', verbose: true });
+      plugin.log(`${serviceKey} => ${warningMessage}`, { color: 'yellow', verbose: true });
       return RSVP.resolve();
@@ -77,0 +74,0 @@ }

lib/service.js

@@ -1,13 +0,13 @@
-var CoreObject = require('core-object');
-var merge = require('lodash/object/merge');
-var mapValues = require('lodash/object/mapValues');
-var pick = require('lodash/object/pick');
+const CoreObject = require('core-object');
+const merge = require('lodash/object/merge');
+const mapValues = require('lodash/object/mapValues');
+const pick = require('lodash/object/pick');
 
 module.exports = CoreObject.extend({
-  init: function(options) {
+  init(options) {
     this.serviceOptions = merge(options.defaults, options.user, options.hook || {});
   },
 
-  buildServiceCall: function(context) {
-    var opts = mapValues(this.serviceOptions, function(value) {
+  buildServiceCall(context) {
+    let opts = mapValues(this.serviceOptions, function(value) {
       return typeof value === 'function' ? value.bind(this.serviceOptions)(context) : value;
@@ -14,0 +14,0 @@ }.bind(this));

package.json

 {
   "name": "ember-cli-deploy-webhooks",
-  "version": "0.4.2",
+  "version": "1.0.0-beta.1",
   "description": "Ember CLI Deploy plugin for calling webhooks during deployments",
+  "keywords": [
+    "ember-addon",
+    "ember-cli-deploy-plugin"
+  ],
+  "repository": "https://github.com/simplabs/ember-cli-deploy-webhooks",
+  "license": "MIT",
+  "author": "simplabs GmbH",
   "directories": {
@@ -11,43 +18,10 @@ "doc": "doc",
     "build": "ember build",
-    "start": "ember server",
+    "lint:hbs": "ember-template-lint .",
+    "lint:js": "eslint .",
+    "start": "ember serve",
     "test": "node tests/runner.js"
   },
-  "repository": "https://github.com/simplabs/ember-cli-deploy-webhooks",
-  "engines": {
-    "node": ">= 0.10.0"
-  },
-  "author": "simplabs GmbH",
-  "license": "MIT",
-  "devDependencies": {
-    "broccoli-asset-rev": "^2.2.0",
-    "chai": "^3.3.0",
-    "chai-as-promised": "^5.1.0",
-    "ember-cli": "1.13.13",
-    "ember-cli-app-version": "^1.0.0",
-    "ember-cli-content-security-policy": "0.4.0",
-    "ember-cli-dependency-checker": "^1.1.0",
-    "ember-cli-htmlbars": "^1.0.1",
-    "ember-cli-htmlbars-inline-precompile": "^0.3.1",
-    "ember-cli-ic-ajax": "0.2.4",
-    "ember-cli-inject-live-reload": "^1.3.1",
-    "ember-cli-qunit": "^1.0.4",
-    "ember-cli-release": "0.2.8",
-    "ember-cli-sri": "^1.2.0",
-    "ember-cli-uglify": "^1.2.0",
-    "ember-data": "1.13.15",
-    "ember-disable-proxy-controllers": "^1.0.1",
-    "ember-export-application-global": "^1.0.4",
-    "ember-disable-prototype-extensions": "^1.0.0",
-    "ember-try": "~0.0.8",
-    "glob": "^5.0.15",
-    "mocha": "^2.3.3",
-    "nock": "^2.15.0"
-  },
-  "keywords": [
-    "ember-addon",
-    "ember-cli-deploy-plugin"
-  ],
   "dependencies": {
     "core-object": "^1.1.0",
-    "ember-cli-babel": "^5.1.5",
+    "ember-cli-babel": "^6.16.0",
     "ember-cli-deploy-plugin": "0.2.0",
@@ -58,2 +32,39 @@ "lodash": "^3.10.1",
   },
+  "devDependencies": {
+    "@ember/optional-features": "^0.6.3",
+    "broccoli-asset-rev": "^2.7.0",
+    "chai": "^3.5.0",
+    "chai-as-promised": "^5.1.0",
+    "ember-ajax": "^3.1.0",
+    "ember-cli": "~3.4.3",
+    "ember-cli-dependency-checker": "^3.0.0",
+    "ember-cli-eslint": "^4.2.3",
+    "ember-cli-htmlbars": "^3.0.0",
+    "ember-cli-htmlbars-inline-precompile": "^1.0.3",
+    "ember-cli-inject-live-reload": "^1.8.2",
+    "ember-cli-qunit": "^4.3.2",
+    "ember-cli-sri": "^2.1.1",
+    "ember-cli-template-lint": "^1.0.0-beta.1",
+    "ember-cli-uglify": "^2.1.0",
+    "ember-disable-prototype-extensions": "^1.1.3",
+    "ember-export-application-global": "^2.0.0",
+    "ember-load-initializers": "^1.1.0",
+    "ember-maybe-import-regenerator": "^0.1.6",
+    "ember-resolver": "^5.0.1",
+    "ember-source": "~3.4.0",
+    "ember-source-channel-url": "^1.1.0",
+    "ember-try": "^1.0.0",
+    "eslint-config-simplabs": "^0.4.0",
+    "eslint-plugin-ember": "^3.6.2",
+    "eslint-plugin-mocha": "^4.11.0",
+    "eslint-plugin-node": "^7.0.1",
+    "glob": "^5.0.15",
+    "loader.js": "^4.7.0",
+    "mocha": "^2.3.3",
+    "nock": "^2.15.0",
+    "qunit-dom": "^0.7.1"
+  },
+  "engines": {
+    "node": "6.* || 8.* || >= 10.*"
+  },
   "ember-addon": {
@@ -60,0 +71,0 @@ "configPath": "tests/dummy/config"

README.md

@@ -40,3 +40,3 @@ # ember-cli-deploy-webhooks [![Build Status](https://travis-ci.org/simplabs/ember-cli-deploy-webhooks.svg)](https://travis-ci.org/simplabs/ember-cli-deploy-webhooks)
         };
-      }
+      },
       didActivate: true
@@ -85,3 +85,3 @@ }
 
-###services
+### services
 
@@ -98,2 +98,3 @@ An object that identifies all webhooks you want to notify. You will put a key for every service you want to call on deploy here.
 - `auth` used for http-authentication
+- `critical` if true, webhook failures will abort deploy
 
@@ -240,3 +241,3 @@ `auth` should be a hash containing values:
 
-####bugsnag
+#### bugsnag
 
@@ -286,3 +287,3 @@ To configure bugsnag you need to at least provide an `apiKey` and specify
 
-####slack
+#### slack
 
@@ -368,3 +369,3 @@ *Example:*
 
-###httpClient
+### httpClient
 
@@ -371,0 +372,0 @@ The underlying http-library used to send requests to the specified services. This allows users to customize the library that's used for http requests which is useful in tests but might be useful to some users as well. By default the plugin uses [request](https://github.com/request/request).

No alert changes

Improved metrics

Number of lines in readme file

379

increased by0.26%

Worsened metrics

Total package byte prevSize

19802

decreased by-6.32%

Dev dependency count

32

increased by39.13%

Number of package files

9

decreased by-25%

Lines of code

186

decreased by-21.19%

Dependency changes

• + Added@ampproject/remapping@2.3.0(transitive)

• + Added@babel/code-frame@7.26.2(transitive)

• + Added@babel/compat-data@7.26.8(transitive)

• + Added@babel/core@7.26.9(transitive)

• + Added@babel/generator@7.26.9(transitive)

• + Added@babel/helper-compilation-targets@7.26.5(transitive)

• + Added@babel/helper-module-imports@7.25.9(transitive)

• + Added@babel/helper-module-transforms@7.26.0(transitive)

• + Added@babel/helper-string-parser@7.25.9(transitive)

• + Added@babel/helper-validator-identifier@7.25.9(transitive)

• + Added@babel/helper-validator-option@7.25.9(transitive)

• + Added@babel/helpers@7.26.9(transitive)

• + Added@babel/parser@7.26.9(transitive)

• + Added@babel/template@7.26.9(transitive)

• + Added@babel/traverse@7.26.9(transitive)

• + Added@babel/types@7.26.9(transitive)

• + Added@jridgewell/gen-mapping@0.3.8(transitive)

• + Added@jridgewell/resolve-uri@3.1.2(transitive)

• + Added@jridgewell/set-array@1.2.1(transitive)

• + Added@jridgewell/sourcemap-codec@1.5.0(transitive)

• + Added@jridgewell/trace-mapping@0.3.25(transitive)

• + Addedamd-name-resolver@1.2.0(transitive)

• + Addedbabel-code-frame@6.26.0(transitive)

• + Addedbabel-core@6.26.3(transitive)

• + Addedbabel-generator@6.26.1(transitive)

• + Addedbabel-helper-builder-binary-assignment-operator-visitor@6.24.1(transitive)

• + Addedbabel-helper-call-delegate@6.24.1(transitive)

• + Addedbabel-helper-define-map@6.26.0(transitive)

• + Addedbabel-helper-explode-assignable-expression@6.24.1(transitive)

• + Addedbabel-helper-function-name@6.24.1(transitive)

• + Addedbabel-helper-get-function-arity@6.24.1(transitive)

• + Addedbabel-helper-hoist-variables@6.24.1(transitive)

• + Addedbabel-helper-optimise-call-expression@6.24.1(transitive)

• + Addedbabel-helper-regex@6.26.0(transitive)

• + Addedbabel-helper-remap-async-to-generator@6.24.1(transitive)

• + Addedbabel-helper-replace-supers@6.24.1(transitive)

• + Addedbabel-helpers@6.24.1(transitive)

• + Addedbabel-messages@6.23.0(transitive)

• + Addedbabel-plugin-check-es2015-constants@6.22.0(transitive)

• + Addedbabel-plugin-debug-macros@0.2.0(transitive)

• + Addedbabel-plugin-ember-modules-api-polyfill@2.13.4(transitive)

• + Addedbabel-plugin-syntax-async-functions@6.13.0(transitive)

• + Addedbabel-plugin-syntax-exponentiation-operator@6.13.0(transitive)

• + Addedbabel-plugin-syntax-trailing-function-commas@6.22.0(transitive)

• + Addedbabel-plugin-transform-async-to-generator@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-arrow-functions@6.22.0(transitive)

• + Addedbabel-plugin-transform-es2015-block-scoped-functions@6.22.0(transitive)

• + Addedbabel-plugin-transform-es2015-block-scoping@6.26.0(transitive)

• + Addedbabel-plugin-transform-es2015-classes@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-computed-properties@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-destructuring@6.23.0(transitive)

• + Addedbabel-plugin-transform-es2015-duplicate-keys@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-for-of@6.23.0(transitive)

• + Addedbabel-plugin-transform-es2015-function-name@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-literals@6.22.0(transitive)

• + Addedbabel-plugin-transform-es2015-modules-amd@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-modules-commonjs@6.26.2(transitive)

• + Addedbabel-plugin-transform-es2015-modules-systemjs@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-modules-umd@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-object-super@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-parameters@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-shorthand-properties@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-spread@6.22.0(transitive)

• + Addedbabel-plugin-transform-es2015-sticky-regex@6.24.1(transitive)

• + Addedbabel-plugin-transform-es2015-template-literals@6.22.0(transitive)

• + Addedbabel-plugin-transform-es2015-typeof-symbol@6.23.0(transitive)

• + Addedbabel-plugin-transform-es2015-unicode-regex@6.24.1(transitive)

• + Addedbabel-plugin-transform-exponentiation-operator@6.24.1(transitive)

• + Addedbabel-plugin-transform-regenerator@6.26.0(transitive)

• + Addedbabel-plugin-transform-strict-mode@6.24.1(transitive)

• + Addedbabel-polyfill@6.26.0(transitive)

• + Addedbabel-preset-env@1.7.0(transitive)

• + Addedbabel-register@6.26.0(transitive)

• + Addedbabel-runtime@6.26.0(transitive)

• + Addedbabel-template@6.26.0(transitive)

• + Addedbabel-traverse@6.26.0(transitive)

• + Addedbabel-types@6.26.0(transitive)

• + Addedbabylon@6.18.0(transitive)

• + Addedbroccoli-babel-transpiler@6.5.1(transitive)

• + Addedbroccoli-debug@0.6.5(transitive)

• + Addedbroccoli-funnel@2.0.2(transitive)

• + Addedbroccoli-merge-trees@2.0.1(transitive)

• + Addedbroccoli-source@1.1.0(transitive)

• + Addedbrowserslist@3.2.84.24.4(transitive)

• + Addedcaniuse-lite@1.0.30001702(transitive)

• + Addedconvert-source-map@2.0.0(transitive)

• + Addedcore-js@2.6.12(transitive)

• + Addeddebug@4.4.0(transitive)

• + Addeddetect-indent@4.0.0(transitive)

• + Addedelectron-to-chromium@1.5.112(transitive)

• + Addedember-cli-babel@6.18.0(transitive)

• + Addedember-cli-version-checker@2.2.0(transitive)

• + Addedember-rfc176-data@0.3.18(transitive)

• + Addedescalade@3.2.0(transitive)

• + Addedgensync@1.0.0-beta.2(transitive)

• + Addedglobals@11.12.09.18.0(transitive)

• + Addedhome-or-tmp@2.0.0(transitive)

• + Addedinvariant@2.2.4(transitive)

• + Addedjs-tokens@3.0.24.0.0(transitive)

• + Addedjsesc@1.3.03.1.0(transitive)

• + Addedjson5@0.5.12.2.3(transitive)

• + Addedloose-envify@1.4.0(transitive)

• + Addedlru-cache@5.1.1(transitive)

• + Addedmerge-trees@1.0.1(transitive)

• + Addedms@2.1.3(transitive)

• + Addednode-releases@2.0.19(transitive)

• + Addedos-homedir@1.0.2(transitive)

• + Addedpicocolors@1.1.1(transitive)

• + Addedregenerator-runtime@0.10.50.11.1(transitive)

• + Addedregenerator-transform@0.10.1(transitive)

• + Addedregexpu-core@2.0.0(transitive)

• + Addedrepeating@2.0.1(transitive)

• + Addedrsvp@4.8.5(transitive)

• + Addedsemver@6.3.1(transitive)

• + Addedsource-map-support@0.4.18(transitive)

• + Addedtree-sync@1.4.0(transitive)

• + Addedupdate-browserslist-db@1.1.3(transitive)

• + Addedyallist@3.1.1(transitive)

• - Removedacorn@5.7.4(transitive)

• - Removedalign-text@0.1.4(transitive)

• - Removedalter@0.2.0(transitive)

• - Removedamdefine@1.0.1(transitive)

• - Removedast-traverse@0.1.1(transitive)

• - Removedast-types@0.8.120.9.6(transitive)

• - Removedbabel-core@5.8.38(transitive)

• - Removedbabel-plugin-constant-folding@1.0.1(transitive)

• - Removedbabel-plugin-dead-code-elimination@1.0.2(transitive)

• - Removedbabel-plugin-eval@1.0.1(transitive)

• - Removedbabel-plugin-inline-environment-variables@1.0.1(transitive)

• - Removedbabel-plugin-jscript@1.0.4(transitive)

• - Removedbabel-plugin-member-expression-literals@1.0.1(transitive)

• - Removedbabel-plugin-property-literals@1.0.1(transitive)

• - Removedbabel-plugin-proto-to-assign@1.0.4(transitive)

• - Removedbabel-plugin-react-constant-elements@1.0.3(transitive)

• - Removedbabel-plugin-react-display-name@1.0.3(transitive)

• - Removedbabel-plugin-remove-console@1.0.1(transitive)

• - Removedbabel-plugin-remove-debugger@1.0.1(transitive)

• - Removedbabel-plugin-runtime@1.0.7(transitive)

• - Removedbabel-plugin-undeclared-variables-check@1.0.2(transitive)

• - Removedbabel-plugin-undefined-to-void@1.1.6(transitive)

• - Removedbabylon@5.8.38(transitive)

• - Removedbluebird@2.11.0(transitive)

• - Removedbreakable@1.0.0(transitive)

• - Removedbroccoli-babel-transpiler@5.7.4(transitive)

• - Removedbroccoli-funnel@1.2.0(transitive)

• - Removedbroccoli-merge-trees@1.2.4(transitive)

• - Removedcamelcase@1.2.1(transitive)

• - Removedcenter-align@0.1.3(transitive)

• - Removedcliui@2.1.0(transitive)

• - Removedclone@0.2.0(transitive)

• - Removedcommander@2.20.3(transitive)

• - Removedcommoner@0.10.8(transitive)

• - Removedcore-js@1.2.7(transitive)

• - Removeddecamelize@1.2.0(transitive)

• - Removeddefined@1.0.1(transitive)

• - Removeddefs@1.1.1(transitive)

• - Removeddetect-indent@3.0.1(transitive)

• - Removeddetective@4.7.1(transitive)

• - Removedember-cli-babel@5.2.8(transitive)

• - Removedember-cli-version-checker@1.3.1(transitive)

• - Removedesprima@2.7.33.1.3(transitive)

• - Removedesprima-fb@15001.1001.0-dev-harmony-fb(transitive)

• - Removedexists-sync@0.0.4(transitive)

• - Removedfs-readdir-recursive@0.1.2(transitive)

• - Removedget-stdin@4.0.1(transitive)

• - Removedglobals@6.4.1(transitive)

• - Removedgraceful-fs@4.2.11(transitive)

• - Removedhome-or-tmp@1.0.0(transitive)

• - Removediconv-lite@0.4.24(transitive)

• - Removedinvert-kv@1.0.0(transitive)

• - Removedis-buffer@1.1.6(transitive)

• - Removedis-integer@1.0.7(transitive)

• - Removedjs-tokens@1.0.1(transitive)

• - Removedjson5@0.4.0(transitive)

• - Removedkind-of@3.2.2(transitive)

• - Removedlazy-cache@1.0.4(transitive)

• - Removedlcid@1.0.0(transitive)

• - Removedleven@1.0.2(transitive)

• - Removedlongest@1.0.1(transitive)

• - Removedminimatch@2.0.10(transitive)

• - Removedos-locale@1.4.0(transitive)

• - Removedoutput-file-sync@1.1.2(transitive)

• - Removedpath-exists@1.0.0(transitive)

• - Removedq@1.5.1(transitive)

• - Removedrecast@0.10.330.11.23(transitive)

• - Removedregenerator@0.8.40(transitive)

• - Removedregexpu@1.3.0(transitive)

• - Removedrepeat-string@1.6.1(transitive)

• - Removedrepeating@1.1.3(transitive)

• - Removedright-align@0.1.3(transitive)

• - Removedshebang-regex@1.0.0(transitive)

• - Removedsimple-fmt@0.1.0(transitive)

• - Removedsimple-is@0.2.0(transitive)

• - Removedsource-map@0.1.32(transitive)

• - Removedsource-map-support@0.2.10(transitive)

• - Removedstable@0.1.8(transitive)

• - Removedstringmap@0.2.2(transitive)

• - Removedstringset@0.2.1(transitive)

• - Removedthrough@2.3.8(transitive)

• - Removedtry-resolve@1.0.1(transitive)

• - Removedtryor@0.1.2(transitive)

• - Removeduser-home@1.1.1(transitive)

• - Removedwindow-size@0.1.4(transitive)

• - Removedwordwrap@0.0.2(transitive)

• - Removedy18n@3.2.2(transitive)

• - Removedyargs@3.27.0(transitive)

• Updatedember-cli-babel@^6.16.0